-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IE][VPU]: Fixes BinaryEltwise DTS on empty input #3879
[IE][VPU]: Fixes BinaryEltwise DTS on empty input #3879
Conversation
...ine/src/vpu/common/src/ngraph/transformations/dynamic_to_static_shape_binary_elementwise.cpp
Outdated
Show resolved
Hide resolved
@andrejsokolov @AndrewBakalinIntel ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add a couple of tests on inference?
...ine/src/vpu/common/src/ngraph/transformations/dynamic_to_static_shape_binary_elementwise.cpp
Outdated
Show resolved
Hide resolved
I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono). @mikhail-treskin do you know anything about it? Should I raise a ticket on this? |
@mikhail-treskin ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update copyrights as well.
...ine/src/vpu/common/src/ngraph/transformations/dynamic_to_static_shape_binary_elementwise.cpp
Outdated
Show resolved
Hide resolved
...ine/src/vpu/common/src/ngraph/transformations/dynamic_to_static_shape_binary_elementwise.cpp
Outdated
Show resolved
Hide resolved
...ine/src/vpu/common/src/ngraph/transformations/dynamic_to_static_shape_binary_elementwise.cpp
Outdated
Show resolved
Hide resolved
Do you mean static cases or dynamic? Or they both failed? |
Dynamic |
@andrejsokolov please take a look |
Signed-off-by: Gladilov, Gleb <[email protected]>
Signed-off-by: Gladilov, Gleb <[email protected]>
Description
Makes DTS for BinaryEltwise produce empty output tensor in case if at least one input is empty. As a criteria for empty tensor ReduceMin is used (assuming all shape's values are non-negative).
Tests are changed accordingly. Trying to add new test case on inference with empty input, reference version failed, so those tests are left unchanged.
Task
#-46858