Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE][VPU]: Fixes BinaryEltwise DTS on empty input #3879

Merged
merged 2 commits into from
Feb 8, 2021
Merged

[IE][VPU]: Fixes BinaryEltwise DTS on empty input #3879

merged 2 commits into from
Feb 8, 2021

Conversation

ggladilov
Copy link
Contributor

Description

Makes DTS for BinaryEltwise produce empty output tensor in case if at least one input is empty. As a criteria for empty tensor ReduceMin is used (assuming all shape's values are non-negative).

Tests are changed accordingly. Trying to add new test case on inference with empty input, reference version failed, so those tests are left unchanged.

Task

#-46858

@ggladilov ggladilov added this to the 2021.3 milestone Jan 15, 2021
@ggladilov ggladilov requested review from andrejsokolov and a user January 15, 2021 13:37
@ggladilov ggladilov assigned ghost Jan 15, 2021
@ggladilov ggladilov requested a review from a team January 15, 2021 13:37
@ggladilov ggladilov requested a review from a team as a code owner January 15, 2021 13:37
@openvino-pushbot openvino-pushbot added the category: IE Tests OpenVINO Test: plugins and common label Jan 15, 2021
@ggladilov
Copy link
Contributor Author

@andrejsokolov @AndrewBakalinIntel ping

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a couple of tests on inference?

@ggladilov
Copy link
Contributor Author

Could you please also add a couple of tests on inference?

I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono).

@mikhail-treskin do you know anything about it? Should I raise a ticket on this?

@ggladilov ggladilov requested a review from a user January 22, 2021 16:29
@ggladilov
Copy link
Contributor Author

Could you please also add a couple of tests on inference?

I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono).

@mikhail-treskin do you know anything about it? Should I raise a ticket on this?

@mikhail-treskin ping

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update copyrights as well.

@ghost
Copy link

ghost commented Feb 4, 2021

Could you please also add a couple of tests on inference?

I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono).

@mikhail-treskin do you know anything about it? Should I raise a ticket on this?

Do you mean static cases or dynamic? Or they both failed?

@ggladilov
Copy link
Contributor Author

Could you please also add a couple of tests on inference?

I tried to add some inference tests with empty input, but reference implementation failed for some reason on those cases (discussed offline with @itikhono).
@mikhail-treskin do you know anything about it? Should I raise a ticket on this?

Do you mean static cases or dynamic? Or they both failed?

Dynamic

@ggladilov ggladilov requested review from a team February 5, 2021 11:52
@ggladilov
Copy link
Contributor Author

@andrejsokolov please take a look

@Maxim-Doronin Maxim-Doronin merged commit 785828d into openvinotoolkit:master Feb 8, 2021
@ggladilov ggladilov deleted the vpu/gg/fixes-binary-eltwise-dts-on-empty-input branch February 9, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants