Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maxpool spec update #3758

Merged
merged 30 commits into from
Feb 5, 2021
Merged

Maxpool spec update #3758

merged 30 commits into from
Feb 5, 2021

Conversation

pszmel
Copy link
Contributor

@pszmel pszmel commented Dec 28, 2020 •
edited
Loading

  1. Update max pool spec

ticket: 43356

@pszmel pszmel added the category: Core OpenVINO Core (aka ngraph) label Dec 28, 2020
@pszmel pszmel self-assigned this Dec 28, 2020
@pszmel pszmel marked this pull request as ready for review January 11, 2021 12:38
@pszmel pszmel requested a review from a team as a code owner January 11, 2021 12:38
rkazants
rkazants reviewed Jan 13, 2021
View reviewed changes
docs/ops/pooling/MaxPool_1.md Outdated Show resolved Hide resolved
docs/ops/pooling/MaxPool_1.md Outdated Show resolved Hide resolved
@pszmel pszmel requested a review from rkazants January 13, 2021 19:21
rkazants
rkazants reviewed Jan 18, 2021
View reviewed changes
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

@rkazants
Copy link
Contributor

@lazarevevgeny, could you please review the update and merge once no concern? The specification gets much better by Piotr's effort.

lazarevevgeny
lazarevevgeny suggested changes Jan 31, 2021
View reviewed changes
docs/ops/pooling/MaxPool_1.md Outdated Show resolved Hide resolved
docs/ops/pooling/MaxPool_1.md Outdated Show resolved Hide resolved
docs/ops/pooling/MaxPool_1.md Outdated Show resolved Hide resolved
@pszmel pszmel requested a review from lazarevevgeny February 1, 2021 13:58
lazarevevgeny
lazarevevgeny suggested changes Feb 2, 2021
View reviewed changes
docs/ops/pooling/MaxPool_1.md Show resolved Hide resolved
docs/ops/pooling/MaxPool_1.md Outdated Show resolved Hide resolved
docs/ops/pooling/MaxPool_1.md Outdated Show resolved Hide resolved
@lazarevevgeny lazarevevgeny merged commit 9695076 into openvinotoolkit:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants approved these changes

@jdanieck jdanieck jdanieck approved these changes

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@alexey-varyzgin alexey-varyzgin Awaiting requested review from alexey-varyzgin

@ilyachur ilyachur Awaiting requested review from ilyachur

Assignees

@pszmel pszmel

Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pszmel @rkazants @ilyachur @lazarevevgeny @jdanieck