Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align location to OMZ demos #3754

Merged
merged 37 commits into from
Jan 12, 2021

Conversation

slyubimt
Copy link
Contributor

@slyubimt slyubimt commented Dec 28, 2020

  • Use real location instead of symlink.

…ster

# Conflicts:
#	model-optimizer/CMakeLists.txt
@slyubimt slyubimt requested review from a team December 28, 2020 12:18
@slyubimt slyubimt requested a review from a team as a code owner December 28, 2020 12:18
@ilya-lavrenov
Copy link
Contributor

why DLDT should install demos? I disagree with the approach. Demo should be installed by themselves.

@slyubimt
Copy link
Contributor Author

why DLDT should install demos? I disagree with the approach. Demo should be installed by themselves.

A motivation for this to is have ability for the end user from single repo to have OMZ content by executing make build & install

@ilya-lavrenov
Copy link
Contributor

why DLDT should install demos? I disagree with the approach. Demo should be installed by themselves.

A motivation for this to is have ability for the end user from single repo to have OMZ content by executing make build & install

It's not scalable for all other repositories which provides artifacts for OpenVINO package.

@slyubimt slyubimt changed the title Enable make install support in OMZ demos (29639) Align location to OMZ demos Jan 12, 2021
@ilya-lavrenov ilya-lavrenov self-assigned this Jan 12, 2021
@ilya-lavrenov ilya-lavrenov added the category: build OpenVINO cmake script / infra label Jan 12, 2021
@ilya-lavrenov ilya-lavrenov added this to the 2021.3 milestone Jan 12, 2021
@ilya-lavrenov ilya-lavrenov merged commit 51f3b33 into openvinotoolkit:master Jan 12, 2021
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Jan 14, 2021
* [MO] Add CMake install for Model Optimizer

* [MO] Update test for version.py

* [MO] Add CMake install for Model Optimizer

* [MO] Update test for version.py

* [MO] Add CMake install for Model Optimizer

* [MO] Update test for version.py

* [MO] fix file permissions for install location

* enable make install for OMZ

* Add option description

* remove OMZ fetching & install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: build OpenVINO cmake script / infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants