Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mapping of input name #3737

Merged
merged 10 commits into from
Dec 28, 2020
Merged

Fixed mapping of input name #3737

merged 10 commits into from
Dec 28, 2020

Conversation

popovaan
Copy link
Contributor

@popovaan popovaan commented Dec 24, 2020 •
edited
Loading

Description: Fixed bug in mapping of input name which occurred when mean and scale preprocessing is added to model.

JIRA: 28545

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests - N/A
  • Transformation tests
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py - N/A
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list - N/A
  • Supported public models list - N/A
  • New operations specification - N/A
  • Guide on how to convert the public model - N/A
  • User guide update - N/A

@popovaan popovaan requested a review from a team December 24, 2020 21:18
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Dec 24, 2020
@andrei-kochin andrei-kochin requested review from a team, iimironov, rkazants and vgavrilo and removed request for a team December 24, 2020 22:41
@popovaan popovaan requested a review from a team December 25, 2020 10:09
@lazarevevgeny lazarevevgeny removed the request for review from a team December 28, 2020 13:45
rkazants
rkazants approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a comment. I suggest fixing it.

@lazarevevgeny lazarevevgeny merged commit 631d452 into openvinotoolkit:master Dec 28, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Jan 14, 2021
@popovaan @mryzhov
Fixed mapping of input name (openvinotoolkit#3737)
8f808f8 
* Fixed mapping of input name

* Fixed unit tests

* Fixed mapping of input name

* Fixed unit tests

* attributes check fix

* PEP8 code format

* code duplicate removal

* variable rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgavrilo vgavrilo vgavrilo approved these changes

@rkazants rkazants rkazants approved these changes

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@iimironov iimironov Awaiting requested review from iimironov

Assignees
No one assigned
Labels
category: MO Model Optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@popovaan @lazarevevgeny @rkazants @vgavrilo @openvino-pushbot