Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed OV_SCOPE semantic #3692

Merged
merged 8 commits into from
Dec 22, 2020
Merged

Changed OV_SCOPE semantic #3692

merged 8 commits into from
Dec 22, 2020

Conversation

ilyachur
Copy link
Contributor

@ilyachur ilyachur commented Dec 21, 2020 •
edited
Loading

Changed semantic of OV_SCOPE command from:

OV_SCOPE(CC, scope,
    std::cout << "Hello world!" << std::endl);

to:

OV_SCOPE(CC, scope) {
    std::cout << "Hello world!" << std::endl;
}

or

OV_SCOPE(CC, scope) std::cout << "Hello world!" << std::endl;

@vladislav-volkov vladislav-volkov self-requested a review December 22, 2020 08:25
@ilyachur ilyachur changed the title Added if DEFINE construction Changed OV_SCOPE semantic Dec 22, 2020
@ilyachur ilyachur added this to the 2021.3 milestone Dec 22, 2020
@ilyachur ilyachur added category: inference OpenVINO Runtime library - Inference category: Core OpenVINO Core (aka ngraph) labels Dec 22, 2020
@ilyachur ilyachur marked this pull request as ready for review December 22, 2020 09:42
@ilyachur ilyachur requested review from a team December 22, 2020 09:42
nkogteva
nkogteva approved these changes Dec 22, 2020
View reviewed changes
ngraph/core/src/op/prelu.cpp Outdated Show resolved Hide resolved
@ilyachur ilyachur merged commit 1926179 into openvinotoolkit:master Dec 22, 2020
@ilyachur ilyachur deleted the cc_if branch December 22, 2020 15:29
@ilyachur ilyachur mentioned this pull request Dec 24, 2020
Merged
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Jan 14, 2021
@ilyachur @mryzhov
Changed OV_SCOPE semantic (openvinotoolkit#3692)
3a16a61 
* Added if DEFINE construction

* Changed OV_SCOPE semantic

* Fixed the code style

* Fixed redundant lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkogteva nkogteva nkogteva approved these changes

@vladislav-volkov vladislav-volkov vladislav-volkov approved these changes

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
2021.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyachur @nkogteva @vladislav-volkov