[VPU][TESTS]Fix myriad tests on MacOS #3681
Conversation
...e/tests_deprecated/functional/vpu/common/layers/myriad_layers_exp_generateproposals_test.hpp
Outdated
Show resolved
Hide resolved
PoliOwl
force-pushed
the
fixMyriadTestsOnMacOS
branch
from
fc2de7c to
f8cae70
Compare
PoliOwl
force-pushed
the
fixMyriadTestsOnMacOS
branch
2 times, most recently
from
45f6bd6 to
90b4f98
Compare
| @@ -24,7 +24,7 @@ void dynamicToStaticShapeSqueeze(std::shared_ptr<ngraph::Node> target) { | |||
| target, ngraph::opset3::Squeeze::type_info); | |||
|
|
|||
| const auto dsr = target->input_value(0).get_node_shared_ptr(); | |||
| VPU_THROW_UNLESS(std::dynamic_pointer_cast<ngraph::vpu::op::DynamicShapeResolver>(dsr), | |||
| VPU_THROW_UNLESS(ngraph::is_type<ngraph::vpu::op::DynamicShapeResolver>(dsr), | |||
There was a problem hiding this comment.
Why dynamic_pointer_cast does not work?
CC @ilyachur
There was a problem hiding this comment.
Looks like it is an internal VPU node has some issues with RTTI?
Am I right? Or in other case should dynamic_pointer_cast and is_type should produce the same result.
There was a problem hiding this comment.
It looks like this problem only occurs on MacOS, and cases segmentation fault, but is_type works fine
I've tried to directly turn on RTTI, but it didn't help
There was a problem hiding this comment.
RTTI is enabled by default. We had the same problems when symbols aren't exported from the library. I am not sure that it is your case, need to check.
There was a problem hiding this comment.
How did you discovered your problem?
There was a problem hiding this comment.
@PoliOwl the issue usually happens when you use dynamic cast to a type which is located in a different shared library (in this case class must be export from that library). E.g. I believe if the issue comes when you cast to ngraph type which is not exported, but these types are located inside your library and the issue should not happen...
Try to build with clang and -fsanitize=vptr (see https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html) and run this test.
| @@ -140,7 +140,11 @@ static void genInputs(InferenceEngine::BlobMap inputMap, | |||
| inputIMinfo[1] = PrecisionUtils::f32tof16( (float) imgW ); | |||
| } | |||
|
|
|||
| #ifdef __APPLE__ | |||
| TEST_P(myriadLayersTestsExpGenerateProposals_smoke, DISABLED_ExpGenerateProposals) { | |||
There was a problem hiding this comment.
Why did you disable some tests for macOS? Is it related with RTTI issues?
There was a problem hiding this comment.
This tests fails on MacOS, but this problem is depended on input data, which generates randomly, so it very hard to reproduce, and since those are deprecated tests, they were disabled. As far as I can tell they don't relate to the RTTI issues
There was a problem hiding this comment.
Maybe some variable or class member isn't initialised and it causes the issue... Do you have a plan to move this test on new infrastructure and enable it?
There was a problem hiding this comment.
there is plans for moving tests, but with a very low priority
PoliOwl
force-pushed
the
fixMyriadTestsOnMacOS
branch
from
90b4f98 to
715ad4a
Compare
…henged dynamic_pointer_cast to ngraph::is_type at dynamic_to_static_shape_squeeze.cpp
…moke.ExpGenerateProposals tests for macOS
PoliOwl
force-pushed
the
fixMyriadTestsOnMacOS
branch
from
715ad4a to
ccab9d5
Compare
|
@PoliOwl, I'm merging the PR to fix functional tests on MacOS on VPU CI. |
* fix sorting ref for myriadTestsTopK_smoke on macOS and chenged dynamic_pointer_cast to ngraph::is_type at dynamic_to_static_shape_squeeze.cpp * disable accuracy/myriadLayersTestsExpGenerateProposals_smoke.ExpGenerateProposals tests for macOS
fix for myriadTestsTopK_smoke and smoke_DynamicSqueeze/DSR_Squeeze for MacOS
disable deprecated myriadLayersTestsExpGenerateProposals_smoke for macOS