Avgpool revise #3674
Merged
Avgpool revise #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues for rounding_type and pad_type
…nv, conv, deformable_conv, group_conv and max_pool
pszmel
requested review from
a team,
ilyachur,
ggalieroc-zz,
pelszkow and
lazarevevgeny
pelszkow
reviewed
Dec 21, 2020
lazarevevgeny
suggested changes
Dec 28, 2020
mbencer
approved these changes
Jan 5, 2021
|
Pooling from ONNX supports 1D and 2D cases. How to deal with it? Do we need new ops in new version? |
lazarevevgeny
suggested changes
Jan 12, 2021
...nce-engine/tests/functional/plugin/cpu/shared_tests_instances/single_layer_tests/pooling.cpp
Outdated
Show resolved
Hide resolved
lazarevevgeny
approved these changes
Jan 13, 2021
ilyachur
approved these changes
Jan 13, 2021
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
* Update the spec * add unit-tests * add avgPool unit-tests to CMakelist * Remove second constructor and change the first one to take default values for rounding_type and pad_type * add type_prop test for default values * add 5d input single layer test instances * add type_prop tests * Require input to be 4D or 5D * add validation check for pads size * Update few tests to take 5D input instead of 6D * Update validate_and_infer_types method * Update infer_batched_pooling_forward and try_apply_auto_padding methods * Update auto_padding_spatial_dims_dynamic type_prop test for binary_conv, conv, deformable_conv, group_conv and max_pool * style-apply * add validation check for kernel size * add xfail for avgpool python backend test * style-apply * remove avgpool backend test from xfail list * Update spec * Allow the 3D input * Update type_prop test with 3D input * style-apply * Remove xfail_issue_38709 * fix typo * Update spec * Update outputs section in spec * Update spec * fix typo * clean file * Update detailed description and fix xml examples * fix exclude-type typo * fix typo in outputs section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in infer_batched_pooling_forward and try_apply_auto_padding required me to change the expected pads_begin and pads_end in 1 type_prop test for ops listed in point 8.
ticket: 37422