Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Conditional Compilation for nGraph evaluate methods #3666

Merged
merged 9 commits into from
Dec 21, 2020

Conversation

ilyachur
Copy link
Contributor

@ilyachur ilyachur commented Dec 18, 2020

In this PR I have added the new macros to enable conditional compilation for nGraph.

And also I changed implementations of all existed evaluate methods to these macros.

@ilyachur ilyachur added the category: Core OpenVINO Core (aka ngraph) label Dec 18, 2020
@ilyachur ilyachur added this to the 2021.3 milestone Dec 18, 2020
@ilyachur ilyachur requested review from nkogteva, vladislav-volkov and a team December 18, 2020 08:09
@ilyachur ilyachur force-pushed the feature/ichuraev/ngraph_cc branch 2 times, most recently from a518013 to ac8c918 Compare December 18, 2020 08:48
@ilyachur ilyachur changed the title Enable CC macro for nGraph Enable Conditional Compilation for nGraph evaluate methods Dec 18, 2020
@ilyachur ilyachur force-pushed the feature/ichuraev/ngraph_cc branch from ac8c918 to 6564278 Compare December 18, 2020 09:23
Copy link
Contributor

@vladislav-volkov vladislav-volkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should come up something for conditionally cut out whole function. (:

ngraph/core/CMakeLists.txt Outdated Show resolved Hide resolved
ngraph/core/src/itt.hpp Show resolved Hide resolved
@ilyachur ilyachur force-pushed the feature/ichuraev/ngraph_cc branch from 59c1d9e to 21850b5 Compare December 18, 2020 11:24
ngraph/core/src/op/abs.cpp Outdated Show resolved Hide resolved
ngraph/core/src/op/multiply.cpp Outdated Show resolved Hide resolved
ngraph/core/src/op/reduce_l1.cpp Outdated Show resolved Hide resolved
ngraph/core/src/op/xor.cpp Outdated Show resolved Hide resolved
@ilyachur ilyachur force-pushed the feature/ichuraev/ngraph_cc branch from 71afb71 to 29304c9 Compare December 18, 2020 16:37
@ilyachur ilyachur force-pushed the feature/ichuraev/ngraph_cc branch from 29304c9 to 98821ab Compare December 18, 2020 16:41
@ilyachur ilyachur force-pushed the feature/ichuraev/ngraph_cc branch from e7766fa to 2d75c31 Compare December 18, 2020 17:15
@ilyachur ilyachur requested review from tomdol and nkogteva December 20, 2020 19:56
@ilyachur ilyachur force-pushed the feature/ichuraev/ngraph_cc branch from 3af7102 to fc2af32 Compare December 21, 2020 07:49
@ilyachur ilyachur merged commit b2399ce into openvinotoolkit:master Dec 21, 2020
@ilyachur ilyachur deleted the feature/ichuraev/ngraph_cc branch December 21, 2020 11:32
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Jan 14, 2021
…oolkit#3666)

* Added CC macro to nGraph

* Add CC to evaluate methods

* Fixed tests

* Fixed comments

* Add private evaluates

* Fixed code style and names

* Fixed code style

* Fixed build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants