-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Conditional Compilation for nGraph evaluate methods #3666
Merged
ilyachur
merged 9 commits into
openvinotoolkit:master
from
ilyachur:feature/ichuraev/ngraph_cc
Dec 21, 2020
Merged
Enable Conditional Compilation for nGraph evaluate methods #3666
ilyachur
merged 9 commits into
openvinotoolkit:master
from
ilyachur:feature/ichuraev/ngraph_cc
Dec 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyachur
force-pushed
the
feature/ichuraev/ngraph_cc
branch
2 times, most recently
from
December 18, 2020 08:48
a518013
to
ac8c918
Compare
ilyachur
changed the title
Enable CC macro for nGraph
Enable Conditional Compilation for nGraph evaluate methods
Dec 18, 2020
ilyachur
assigned postrational, tomdol and jdanieck and unassigned postrational, tomdol and jdanieck
Dec 18, 2020
ilyachur
force-pushed
the
feature/ichuraev/ngraph_cc
branch
from
December 18, 2020 09:23
ac8c918
to
6564278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should come up something for conditionally cut out whole function. (:
ilyachur
force-pushed
the
feature/ichuraev/ngraph_cc
branch
from
December 18, 2020 11:24
59c1d9e
to
21850b5
Compare
ilya-lavrenov
approved these changes
Dec 18, 2020
ilya-lavrenov
approved these changes
Dec 18, 2020
jdanieck
approved these changes
Dec 18, 2020
nkogteva
reviewed
Dec 18, 2020
nkogteva
reviewed
Dec 18, 2020
tomdol
reviewed
Dec 18, 2020
ilyachur
force-pushed
the
feature/ichuraev/ngraph_cc
branch
from
December 18, 2020 16:37
71afb71
to
29304c9
Compare
ilyachur
force-pushed
the
feature/ichuraev/ngraph_cc
branch
from
December 18, 2020 16:41
29304c9
to
98821ab
Compare
ilyachur
force-pushed
the
feature/ichuraev/ngraph_cc
branch
from
December 18, 2020 17:15
e7766fa
to
2d75c31
Compare
vladislav-volkov
approved these changes
Dec 21, 2020
ilyachur
force-pushed
the
feature/ichuraev/ngraph_cc
branch
from
December 21, 2020 07:49
3af7102
to
fc2af32
Compare
tomdol
approved these changes
Dec 21, 2020
pelszkow
approved these changes
Dec 21, 2020
nkogteva
approved these changes
Dec 21, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
…oolkit#3666) * Added CC macro to nGraph * Add CC to evaluate methods * Fixed tests * Fixed comments * Add private evaluates * Fixed code style and names * Fixed code style * Fixed build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added the new macros to enable conditional compilation for nGraph.
And also I changed implementations of all existed evaluate methods to these macros.