module library type for IE plugins, extensions #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-lavrenov
added
category: build
ilya-lavrenov
force-pushed
the
try-module
branch
from
6a15c2b to
80ec2fc
Compare
ilya-lavrenov
requested review from
asuhov,
ilyachur,
slyubimt,
artanokhov,
SDxKeeper and
mshabunin
ilyachur
reviewed
Dec 18, 2020
ilyachur
approved these changes
Dec 18, 2020
|
Blocked by opencv |
slyubimt
reviewed
Dec 25, 2020
| @@ -52,7 +52,7 @@ function(ie_add_plugin) | |||
| add_cpplint_target(${obj_lib}_cpplint FOR_TARGETS ${obj_lib}) | |||
| endforeach() | |||
|
|
|||
| add_library(${IE_PLUGIN_NAME} SHARED ${input_files}) | |||
| add_library(${IE_PLUGIN_NAME} MODULE ${input_files}) | |||
There was a problem hiding this comment.
MODULE is considered as library object on Windows. This means here and for other modules
LIBRARY DESTINATION shall be defined to IE_CPACK_RUNTIME_PATH on Windows to preserve current install location for these libs.
LIBRARY DESTINATION ${IE_CPACK_RUNTIME_PATH} COMPONENT ${install_component}
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
* CMAKE: Added MODULE linker flags * Fixed plugins.xml s * Use module instead of shared library * Fixes * tab 2 spaces * Renamed get_shared_library_name to ie_plugin_get_file_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with openvinotoolkit/testdata#4
It should not break compatibility since:
extensions.dylibis still supported.DYLD_LIBRARY_PATHandLD_LIBRARY_PATHto the same values.