create_emitters_for_load_and_store #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
2 times, most recently
from
a149beb to
52ead35
Compare
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
from
2a9562a to
db515ad
Compare
maxnick
reviewed
Dec 25, 2020
inference-engine/src/mkldnn_plugin/nodes/common/jit_load_store_emitters.cpp
Show resolved
Hide resolved
maxnick
reviewed
Dec 25, 2020
inference-engine/src/mkldnn_plugin/nodes/common/jit_load_store_emitters.cpp
Outdated
Show resolved
Hide resolved
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
10 times, most recently
from
717a604 to
29e5501
Compare
|
@chenhu-wang how is it going here? Is the feature ready for review? |
The load/store emitter itself can be reviewed here I think. I am now trying to apply load/store emitter to MVN layer to make an example on how to use this emitter and have a test if emitter does work correctly and performance impact. |
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
9 times, most recently
from
30f5e33 to
3dcd010
Compare
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
3 times, most recently
from
13d67a8 to
77f88d1
Compare
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
from
b1a1cfb to
17195f4
Compare
|
@dmitry-gorokhov , as discussed offline, an overloaded emit() and index of size_t is updated by e158be0. Could you please take a look. |
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
from
04665a6 to
e158be0
Compare
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
from
67e116b to
6a7a844
Compare
…port more layout and dt
…check, default p_table, clear comments
chenhu-wang
force-pushed
the
chenhu/emitter_for_load_store
branch
from
a0312a3 to
78635df
Compare
dmitry-gorokhov
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create emitters for jitted load and store and apply to MVN node (issue#: 44528)
MVN template function removal (issue#: 34426)
optimize tiles processing in MVN node implementation and refactor (issue#: 46190)