CMake Doc Link Checker #3403
Merged
CMake Doc Link Checker #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyachur
approved these changes
Nov 30, 2020
| exclude_links: | ||
| - '.*?\@ref omz.*' | ||
| - '.*?\@ref pot.*' | ||
| - '.*?\@ref workbench.*' |
There was a problem hiding this comment.
am I right that all other links are correct? I don't believe in it 😄
| @@ -202,6 +202,11 @@ function(build_docs) | |||
| COMMENT "Generating OpenVINO documentation" | |||
| VERBATIM) | |||
|
|
|||
| add_custom_target(docs_check | |||
| COMMAND ${Python3_EXECUTABLE} ${LINKCHECKER_EXECUTABLE} ${DOCS_BUILD_DIR}/html/ -f ${DOXYGEN_DIR}/linkchecker_filter.yaml --no_recursive -l ${DOCS_BUILD_DIR} | |||
There was a problem hiding this comment.
LINKCHECKER_EXECUTABLE is empty since it's not defined in the project. Let's add LINKCHECKER_EXECUTABLE option to cmake/features.cmake and enable this step only if LINKCHECKER_EXECUTABLE is defined and file exists.
BTW, since this is a python script, can we rename to LINKCHECKER_PY?
There was a problem hiding this comment.
paths like ${DOCS_BUILD_DIR}/html/ must be quoted with "
evolosen
pushed a commit
to evolosen/openvino
that referenced
this pull request
Dec 3, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 11, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Dec 16, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
jiwaszki
pushed a commit
to akuporos/openvino
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.