CMake based build for pyngraph module #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyubimt
added
category: Core
ilyachur
reviewed
Nov 11, 2020
…slyubimt/openvino into features/cmake_install_pyngraph
andrew-zaytsev
suggested changes
Nov 27, 2020
andrew-zaytsev
approved these changes
Dec 3, 2020
|
LGTM |
…slyubimt/openvino into features/cmake_install_pyngraph
|
This PR wasn't fully tested on Windows, but if we face issues, we can resolve them in future PRs. |
postrational
approved these changes
Dec 23, 2020
|
@slyubimt Please update your PR to the latest master. |
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Jan 14, 2021
* [MO] Add CMake install for Model Optimizer * [MO] Update test for version.py * [MO] Add CMake install for Model Optimizer * [MO] Update test for version.py * [MO] Add CMake install for Model Optimizer * [MO] Update test for version.py * [nGraph] Python API should be compiled and installed via CMake (41857) * Refactored wheel setup script to build module using CMake * Update build instructions * Added USE_SOURCE_PERMISSIONS to cmake install * Adjust CMake compiler flags conditions * fix CPack issue for CI build pipeline * case insensitive option check * build only python API if ngraph_DIR provided * fix lib extension for macOS * -fixed style (flake8) -added paralllel build option & description * fix flake8 B006 check * add ngraph_DIR & remove unsed env. variables. * Reworked build & test instructions to make it more straightforward * remove unused CMake arguments for setup.py * make source dir condition more general * Update BUILDING.md * Update BUILDING.md * Update BUILDING.md * beautified instructions wording * fix wheel build issue after sourcing setupvars * Extend user options to build, install and develop commands Co-authored-by: Andrey Zaytsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is support cmake install functionality for all OpenVINO components, including NGraph python bindings currently bundling using Python setuptools.