Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Add scores output support for PagedAttention #28205

Merged
merged 3 commits into from
Dec 27, 2024
Merged

[GPU] Add scores output support for PagedAttention #28205

merged 3 commits into from
Dec 27, 2024

Conversation

sshlyapn
Copy link
Contributor

@sshlyapn sshlyapn commented Dec 25, 2024 •
edited
Loading

Details:

  • Added scores output support for PagedAttention
  • Added PagedAttention unit tests

Tickets:

@sshlyapn sshlyapn added the category: GPU OpenVINO GPU plugin label Dec 25, 2024
@sshlyapn sshlyapn added this to the 2025.0 milestone Dec 25, 2024
@sshlyapn sshlyapn requested review from a team as code owners December 25, 2024 15:28
@sshlyapn sshlyapn force-pushed the paged_attention_scores_output branch from 8cdd7ba to 88d4d67 Compare December 25, 2024 15:40
@sshlyapn sshlyapn force-pushed the paged_attention_scores_output branch from 88d4d67 to 3233041 Compare December 25, 2024 17:00
Lyamin-Roman
Lyamin-Roman reviewed Dec 25, 2024
View reviewed changes
Copy link
Contributor

@Lyamin-Roman Lyamin-Roman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but please add tests

@sshlyapn sshlyapn force-pushed the paged_attention_scores_output branch from 06dab62 to 82ae611 Compare December 26, 2024 18:27
@p-durandin p-durandin added this pull request to the merge queue Dec 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2024
@p-durandin p-durandin added this pull request to the merge queue Dec 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2024
@p-durandin p-durandin added this pull request to the merge queue Dec 27, 2024
Merged via the queue into openvinotoolkit:master with commit e2ac535 Dec 27, 2024
174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-durandin p-durandin p-durandin approved these changes

@Lyamin-Roman Lyamin-Roman Lyamin-Roman approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sshlyapn @Lyamin-Roman @p-durandin