Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] Set OV model's output's name after parsing model by frontend #28105

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Dec 17, 2024

Details:

  • The model after read by IR frontend shows models output tensors names as Nodes connected to Result's. But by default this names are not dedicated Results name which can cause during pre-post processing that names stay on node and will disapear as model output names. To fix set the names as Results names so during transformations they will stay as model's output names.
  • Onnx frontens set OV model output's names when converting model to OV represenation.
  • Fix NPU test which reports Attempt to get a name for a Tensor without names

Related PRs:

Tickets:

@praasz praasz added this to the 2025.0 milestone Dec 17, 2024
@praasz praasz requested a review from pereanub December 17, 2024 15:28
@praasz praasz requested a review from a team as a code owner December 17, 2024 15:28
@github-actions github-actions bot added the category: IR FE OpenVINO IR v10 / v11 FrontEnd label Dec 17, 2024
Copy link
Contributor

@pereanub pereanub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPU tests looks good. Thx.

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have test(s) for such case?

@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Dec 17, 2024
@ilya-lavrenov ilya-lavrenov removed this pull request from the merge queue due to a manual request Dec 17, 2024
@ilya-lavrenov ilya-lavrenov added the pr: needs tests PR needs tests updating label Dec 17, 2024
src/frontends/ir/src/ir_deserializer.cpp Outdated Show resolved Hide resolved
src/frontends/ir/src/ir_deserializer.cpp Outdated Show resolved Hide resolved
src/frontends/ir/src/ir_deserializer.cpp Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov removed the pr: needs tests PR needs tests updating label Dec 18, 2024
@praasz praasz requested a review from rkazants December 18, 2024 10:29
@praasz praasz requested a review from a team as a code owner December 19, 2024 09:55
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Dec 19, 2024
@praasz praasz changed the title [FE IR] IR de-serializer sets Result tensor names when parsing model [FE] Set OV model's output's name after parsing model by frontend Dec 19, 2024
@mlukasze mlukasze enabled auto-merge December 19, 2024 12:07
@StefaniaHergane
Copy link
Contributor

NPU Jenkins tests are not fully finished but look good so far.

@mlukasze mlukasze added this pull request to the merge queue Dec 19, 2024
Merged via the queue into openvinotoolkit:master with commit b982e19 Dec 19, 2024
218 checks passed
11happy pushed a commit to 11happy/openvino that referenced this pull request Dec 23, 2024
…envinotoolkit#28105)

### Details:
- The model after read by IR frontend shows models output tensors names
as Nodes connected to Result's. But by default this names are not
dedicated Results name which can cause during pre-post processing that
names stay on node and will disapear as model output names. To fix set
the names as Results names so during transformations they will stay as
model's output names.
- Onnx frontens set OV model output's names when converting model to OV
represenation.
- Fix NPU test which reports `Attempt to get a name for a Tensor without
names`

### Related PRs:
- openvinotoolkit#28102

### Tickets:
 - CVS-159401

---------

Signed-off-by: Raasz, Pawel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: IR FE OpenVINO IR v10 / v11 FrontEnd category: ONNX FE OpenVINO ONNX FrontEnd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants