Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Core read_model supports user configuration #28066

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Dec 13, 2024

Details:

  • Extend Core::read_model by additional optimal parameter, properties. The properties passed to read_model are valid only for this usage and will not change Core instance state.
  • Update python API to support new parameter.

Tickets:

@praasz praasz added this to the 2025.0 milestone Dec 13, 2024
@praasz praasz requested review from a team as code owners December 13, 2024 15:06
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: IE Tests OpenVINO Test: plugins and common category: Python API OpenVINO Python bindings category: IR FE OpenVINO IR v10 / v11 FrontEnd category: CPP API OpenVINO CPP API bindings labels Dec 13, 2024
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
@praasz praasz force-pushed the feature/read-model-support-user-configuration branch from 345abad to 7654927 Compare December 17, 2024 11:31
@ilya-lavrenov
Copy link
Contributor

Please, fix:

2024-12-17T16:41:38.4407172Z /__w/openvino/openvino/openvino/src/inference/tests/functional/ov_core_test.cpp:131:33: error: call to member function 'read_model' is ambiguous
2024-12-17T16:41:38.4408182Z   131 |         const auto model = core.read_model(model_path, weight_path);
2024-12-17T16:41:38.4408626Z       |                            ~~~~~^~~~~~~~~~
2024-12-17T16:41:38.4409611Z /__w/openvino/openvino/openvino/src/inference/include/openvino/runtime/core.hpp:114:10: note: candidate function [with Path = std::filesystem::path, $1 = nullptr]
2024-12-17T16:41:38.4411911Z   114 |     auto read_model(const Path& model_path, const Path& bin_path = {}, const ov::AnyMap& properties = {}) const {
2024-12-17T16:41:38.4412824Z       |          ^
2024-12-17T16:41:38.4414347Z /__w/openvino/openvino/openvino/src/inference/include/openvino/runtime/core.hpp:146:10: note: candidate function [with Path = std::filesystem::path, Properties = <>, $2 = nullptr]
2024-12-17T16:41:38.4416396Z   146 |     auto read_model(const Path& model_path, const Path& bin_path, Properties&&... properties) const {
2024-12-17T16:41:38.4417255Z       |          ^
2024-12-17T16:41:38.4417608Z 1 error generated.

@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPP API OpenVINO CPP API bindings category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: IR FE OpenVINO IR v10 / v11 FrontEnd category: Python API OpenVINO Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants