[TRANSFORMATIONS][GPU] SDPA Fusion passes #28042
Open
+822
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-paramuzov
requested review from
itikhono
and removed request for
a team
github-actions
bot
added
category: GPU
vladimir-paramuzov
force-pushed
the
sdpa_fusion
branch
2 times, most recently
from
44480fe to
792a90f
Compare
sshlyapn
reviewed
Dec 13, 2024
Comment on lines
29
to
30
| auto scaled_q = makePattern<ov::op::v1::Multiply>({q, scale_q}); | ||
| auto scaled_k = makePattern<ov::op::v1::Multiply>({k, scale_k}); |
There was a problem hiding this comment.
Doesn't it make sense to make one of these multiply optional?
There was a problem hiding this comment.
Relaxed pattern restrictions to support optional scales + non-constant scale case
vladimir-paramuzov
force-pushed
the
sdpa_fusion
branch
from
792a90f to
54a10c4
Compare
sshlyapn
reviewed
Dec 16, 2024
| pattern_map.at(softmax).get_target_inputs().size() > 1) { | ||
| return false; | ||
| } | ||
| if (pattern_map.count(optional_add_mask) && (pattern_map.at(optional_add_mask).get_target_inputs().size() > 1 || |
There was a problem hiding this comment.
Why do we need this restriction on the number of mask consumers?
There was a problem hiding this comment.
That's not mask consumers, but Add op consumers.
Signed-off-by: Vladimir Paramuzov <[email protected]>
vladimir-paramuzov
force-pushed
the
sdpa_fusion
branch
from
54a10c4 to
83ccfe3
Compare
sshlyapn
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
T5 case