-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CM kernels for GPU #27857
base: master
Are you sure you want to change the base?
Enable CM kernels for GPU #27857
Conversation
* add example cm implementation for fully_connected
@@ -154,7 +154,11 @@ void kernels_cache::get_program_source(const kernels_code& kernels_source_code, | |||
std::string options = kernel_string->options; | |||
bool batch_compilation = kernel_string->batch_compilation; | |||
|
|||
if (batch_compilation) { | |||
bool is_cm = options.find("-cmc") != std::string::npos; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the only way to check that CM compiler is invoked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, OpenCL runtime will use CM compiler only if the -cmc
is present in options provided to clBuildProgram. This is the most straightforward way to check this. Alternatively, we can add is_cm
flag to kernel_string
(src/plugins/intel_gpu/include/intel_gpu/runtime/kernel_args.hpp
) and set it for CM primitives during creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually search in a string being inside a loop is not the most effective way from performance perspective. But overall impact for the app should not be visible I believe. So leaving this for OV guys to suggest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may add enum like KernelLanguage {OCLC, CM}
and make it a part of KernelCode
structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the kernel_language
enum to kernel_string
in 472a46e. Because KernelCode
struct from kernel_selector is not propagated to kernels_cache.
build_jenkins |
@@ -154,7 +154,11 @@ void kernels_cache::get_program_source(const kernels_code& kernels_source_code, | |||
std::string options = kernel_string->options; | |||
bool batch_compilation = kernel_string->batch_compilation; | |||
|
|||
if (batch_compilation) { | |||
bool is_cm = options.find("-cmc") != std::string::npos; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may add enum like KernelLanguage {OCLC, CM}
and make it a part of KernelCode
structure
build_jenkins |
build_jenkins |
build_jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM
@@ -121,6 +121,47 @@ bool query_local_block_io_supported(engine& e, const ExecutionConfig& config) { | |||
|
|||
namespace cldnn { | |||
|
|||
bool check_cm_jit_support(cldnn::engine& e, const cldnn::ExecutionConfig& config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please align the indentation with other code -- we don't use indentation for the content of namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build_jenkins |
build_jenkins |
Details:
Tickets: