[Op][Internal][GPU] SwiGLU op internal common #27579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: GPU
mitruska
commented
Nov 15, 2024
src/plugins/intel_gpu/src/kernel_selector/kernels/swiglu/swiglu_kernel_base.h
Show resolved
Hide resolved
praasz
reviewed
Nov 18, 2024
src/plugins/intel_gpu/src/kernel_selector/kernels/swiglu/swiglu_kernel_base.h
Show resolved
Hide resolved
yeonbok
reviewed
Nov 18, 2024
| public: | ||
| OPENVINO_OP("SwiGLU", "gpu_opset"); | ||
| OPENVINO_OP("SwiGLU", "ie_internal_opset"); |
There was a problem hiding this comment.
Actually, it is "SwiGLU" only when the activation is swish.
If the activatin is gelu, it is "GeGLU".
In gpu plugin, we added Swiglu fisrst, and then, we just did not make effort to update the op name when we newly met Geglu.
However, if we are going to add a common internal op, how about to change the name as GLU with types of swish, gelu?
There was a problem hiding this comment.
I've shared the same idea within the ticket (155542), so I agree the name could be aligned.
(Optional) Rename SwiGLU to more generic name like FuncGLU to avoid confusion
But to keep it simple and don't mix the changes, I would prefer to do it in the following order:
- Move the SwiGLU op as is
- Rename the op
There was a problem hiding this comment.
Ticket number to rename the Swiglu (157623).
There was a problem hiding this comment.
PR renaming SwiGLU to GLU:
mitruska
commented
Nov 19, 2024
| @@ -75,7 +75,7 @@ if(COMMAND add_cpplint_target) | |||
| add_cpplint_target(${TARGET_NAME}_cpplint FOR_TARGETS ${TARGET_NAME}) | |||
| endif() | |||
|
|
|||
| target_link_libraries(${TARGET_NAME} PUBLIC OpenCL::OpenCL openvino::runtime) | |||
| target_link_libraries(${TARGET_NAME} PUBLIC OpenCL::OpenCL openvino::runtime PRIVATE openvino::runtime::dev) | |||
There was a problem hiding this comment.
Needed for visibility of ov_ops/swiglu.hpp in
vladimir-paramuzov
approved these changes
Nov 19, 2024
praasz
approved these changes
Nov 19, 2024
itikhono
approved these changes
Nov 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
### Details: - Rename internal op SwiGLU to GLU (no naming changes for GPU swiglu kernel in this PR) Current SwiGLU can be also GeGLU, it depends on the glu_type member. It has been proposed by several people to rename this op and make the name more generic like GLU. Related comment: #27579 (comment) ### Tickets: - 157623
NishantPrabhuFujitsu
pushed a commit
to NishantPrabhuFujitsu/openvino
that referenced
this pull request
Nov 26, 2024
### Details: - This PR makes GPU SwiGLU to be internal op and swiglu_fusion available in common_optimizations, possible to be reused by other plugins - Only necessary updates including style alignment, no logic or functional changes intended, basically the op has been moved as is, to not complicate review and avoid issues - Needed to link openvino::runtime::dev src/plugins/intel_gpu/src/kernel_selector/CMakeLists.txt https://github.com/openvinotoolkit/openvino/blob/7566bc94c58a501389647b4cc4d7c21df311fa63/src/plugins/intel_gpu/src/kernel_selector/CMakeLists.txt#L78 for visibility of `ov_ops/swiglu.hpp` in https://github.com/openvinotoolkit/openvino/blob/7566bc94c58a501389647b4cc4d7c21df311fa63/src/plugins/intel_gpu/src/kernel_selector/kernels/swiglu/swiglu_kernel_base.h#L9 Tickets for follow ups: 157623, 157615. ### Tickets: - 155542, 138911
NishantPrabhuFujitsu
pushed a commit
to NishantPrabhuFujitsu/openvino
that referenced
this pull request
Nov 26, 2024
### Details: - Rename internal op SwiGLU to GLU (no naming changes for GPU swiglu kernel in this PR) Current SwiGLU can be also GeGLU, it depends on the glu_type member. It has been proposed by several people to rename this op and make the name more generic like GLU. Related comment: openvinotoolkit#27579 (comment) ### Tickets: - 157623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
This PR makes GPU SwiGLU to be internal op and swiglu_fusion available in common_optimizations, possible to be reused by other plugins
Only necessary updates including style alignment, no logic or functional changes intended, basically the op has been moved as is, to not complicate review and avoid issues
Needed to link openvino::runtime::dev src/plugins/intel_gpu/src/kernel_selector/CMakeLists.txt
openvino/src/plugins/intel_gpu/src/kernel_selector/CMakeLists.txt
Line 78 in 7566bc9
ov_ops/swiglu.hppinopenvino/src/plugins/intel_gpu/src/kernel_selector/kernels/swiglu/swiglu_kernel_base.h
Line 9 in 7566bc9
Tickets for follow ups: 157623, 157615.
Tickets: