[GPU] Skip reorder opt when its dependency is crop #27547
Conversation
| @@ -844,6 +844,8 @@ void prepare_buffer_fusing::run(program& p) { | |||
| crop_params->input_offsets[0], | |||
| node.get_primitive()->axis, | |||
| false); | |||
| if (static_cast<bool>(crop_layout.data_padding) && node.get_users().front()->is_type<reorder>()) | |||
There was a problem hiding this comment.
As offline discussion, returning here is dangerous. So this condition must already be done within match function.
steve-y
changed the title
steve-y
force-pushed
the
sy/skip_crop_fusing_before_reorder
branch
from
9e3852a to
0b5aa18
Compare
steve-y
changed the title
steve-y
force-pushed
the
sy/skip_crop_fusing_before_reorder
branch
from
0b5aa18 to
51ac5f3
Compare
steve-y
force-pushed
the
sy/skip_crop_fusing_before_reorder
branch
from
51ac5f3 to
1d15768
Compare
| @@ -295,6 +295,9 @@ void remove_redundant_reorders::run(program& p) { | |||
| auto o_layout = r_node.get_output_layout(); | |||
| const auto& i_layout = r_node.get_input_layout(0); | |||
|
|
|||
| if (r_node.get_dependency(0).is_type<crop>()) | |||
There was a problem hiding this comment.
Do we skip reorder optimizing which has crop dep even it does not has any padding?
There was a problem hiding this comment.
Yes. reorder opt is determined in remove_redundant_reorders and crop padding is determined in prepare_buffer_fusing. And remove_redundant_reorders is executed before prepare_buffer_fusing. So padding info isn't known in remove_redundant_reorders pass.
There was a problem hiding this comment.
if (!update_implementations || (r_node.get_dependency(0).is_type<crop>() && r_node.get_dependency(0).can_be_optimized())
There was a problem hiding this comment.
At post optimization graph phase, update_implementations is true.
At this phase, buffer fusing is already applied, so we can check the optimization of crop.
There was a problem hiding this comment.
Updated as your comments. Thanks for your updated codes and kind explanations.
There was a problem hiding this comment.
As update_implementations needed to be confined to crop only because the code below the condition should be run sometimes, the condition was updated.
steve-y
changed the title
steve-y
force-pushed
the
sy/skip_crop_fusing_before_reorder
branch
3 times, most recently
from
e746860 to
8d5bdd0
Compare
steve-y
force-pushed
the
sy/skip_crop_fusing_before_reorder
branch
from
8d5bdd0 to
0f04110
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
steve-y
force-pushed
the
sy/skip_crop_fusing_before_reorder
branch
3 times, most recently
from
64787a9 to
ba177e8
Compare
Details:
Tickets: