Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRANSFORMATIONS | GPU] Add a Validate pass after MoveEltwiseUpThroughDataMovScalar for element type resolution #27464

Merged

Conversation

CuriousPanCake
Copy link
Contributor

[TRANSFORMATIONS | GPU] Add a Validate pass after MoveEltwiseUpThroughDataMovScalar

After executing the MoveEltwiseUpThroughDataMovScalar transforamtion some node's element types may appear to be in inconsistent/corrupted state. Fix it by inserting a Validate pass after the transformation for resolving the node's element types.

This commit is a workaround until the 141764 is fixed which resolves the issue of Validate passes.

Ticket:

Signed-off-by: Andrii Staikov [email protected]

…ataMovScalar

After executing the MoveEltwiseUpThroughDataMovScalar transforamtion
some node's element types may appear to be in inconsistent/corrupted
state. Fix it by inserting a Validate pass after the transformation.

This commit is a workaround until the 141764 is fixed which resolves
the issue of Validate passes.

Ticket:
* CVS-151111

Signed-off-by: Andrii Staikov <[email protected]>
Copy link
Contributor

@itikhono itikhono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as a temporary solution.
The actual fix here #26705, but it leads to compile time degradation, we are working on its improvement.

@CuriousPanCake
Copy link
Contributor Author

No significant deterioration of compile time observed both for CPU and GPU:

  1. CPU:
    image
  2. GPU:
    image

@CuriousPanCake CuriousPanCake added this pull request to the merge queue Nov 12, 2024
@CuriousPanCake CuriousPanCake removed this pull request from the merge queue due to a manual request Nov 12, 2024
@CuriousPanCake CuriousPanCake added this pull request to the merge queue Nov 13, 2024
Merged via the queue into openvinotoolkit:master with commit acccb22 Nov 13, 2024
150 checks passed
@CuriousPanCake CuriousPanCake deleted the validate_fix_CVS-151111 branch November 13, 2024 11:04
NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
…hDataMovScalar for element type resolution (openvinotoolkit#27464)

[TRANSFORMATIONS | GPU] Add a Validate pass after
MoveEltwiseUpThroughDataMovScalar

After executing the MoveEltwiseUpThroughDataMovScalar transforamtion
some node's element types may appear to be in inconsistent/corrupted
state. Fix it by inserting a Validate pass after the transformation for
resolving the node's element types.

This commit is a workaround until the 141764 is fixed which resolves the
issue of Validate passes.

Ticket:
* CVS-151111

Signed-off-by: Andrii Staikov <[email protected]>

Signed-off-by: Andrii Staikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants