Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] Enable compressed FC via oneDNN Matmul primitive #27459

Conversation

dmitry-gorokhov
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov commented Nov 7, 2024

Details:

  • This PR enables execution FullyConnected operations via OneDNN Matmul Primitive
  • Matmul_weights_decompression tests are splitted on x64 and arm instances, ARM tests run well via ref matmul.
  • Newly added functionality is still under debug caps. To try it out:
    -- Build OV with: -DENABLE_DEBUG_CAPS=ON cmake option
    -- export OV_CPU_ENABLE_DNNL_MAMTUL_FOR_FC=1

@dmitry-gorokhov dmitry-gorokhov added the category: CPU OpenVINO CPU plugin label Nov 7, 2024
@dmitry-gorokhov dmitry-gorokhov added this to the 2025.0 milestone Nov 7, 2024
@dmitry-gorokhov dmitry-gorokhov self-assigned this Nov 7, 2024
@dmitry-gorokhov dmitry-gorokhov requested review from a team as code owners November 7, 2024 13:03
@dmitry-gorokhov dmitry-gorokhov marked this pull request as draft November 7, 2024 13:03
@github-actions github-actions bot added the category: build OpenVINO cmake script / infra label Nov 7, 2024
@dmitry-gorokhov
Copy link
Contributor Author

@EgorDuplensky Please review the PR

@dmitry-gorokhov dmitry-gorokhov marked this pull request as ready for review November 13, 2024 09:53
@dmitry-gorokhov dmitry-gorokhov force-pushed the feature/fc_matmul_with_decompression_executor branch from 7479c09 to 4137826 Compare November 18, 2024 09:11
@dmitry-gorokhov dmitry-gorokhov force-pushed the feature/fc_matmul_with_decompression_executor branch 3 times, most recently from 370e2b2 to 9a336e2 Compare December 12, 2024 11:49
@v-Golubev v-Golubev self-assigned this Dec 17, 2024
@dmitry-gorokhov dmitry-gorokhov force-pushed the feature/fc_matmul_with_decompression_executor branch 3 times, most recently from 983405c to 51b67ca Compare December 18, 2024 13:35
Copy link
Contributor

@v-Golubev v-Golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dmitry-gorokhov dmitry-gorokhov force-pushed the feature/fc_matmul_with_decompression_executor branch from 51b67ca to aa77df7 Compare December 19, 2024 13:09
@github-actions github-actions bot removed the category: build OpenVINO cmake script / infra label Dec 19, 2024
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Dec 19, 2024
Merged via the queue into openvinotoolkit:master with commit e9400c5 Dec 19, 2024
184 checks passed
@dmitry-gorokhov dmitry-gorokhov deleted the feature/fc_matmul_with_decompression_executor branch December 19, 2024 16:53
11happy pushed a commit to 11happy/openvino that referenced this pull request Dec 23, 2024
…it#27459)

### Details:
- This PR enables execution FullyConnected operations via OneDNN Matmul
Primitive
- Matmul_weights_decompression tests are splitted on x64 and arm
instances, ARM tests run well via ref matmul.
- Newly added functionality is still under debug caps. To try it out:
-- Build OV with: -DENABLE_DEBUG_CAPS=ON cmake option
-- export OV_CPU_ENABLE_DNNL_MAMTUL_FOR_FC=1
MirceaDan99 pushed a commit to MirceaDan99/openvino that referenced this pull request Jan 22, 2025
…it#27459)

### Details:
- This PR enables execution FullyConnected operations via OneDNN Matmul
Primitive
- Matmul_weights_decompression tests are splitted on x64 and arm
instances, ARM tests run well via ref matmul.
- Newly added functionality is still under debug caps. To try it out:
-- Build OV with: -DENABLE_DEBUG_CAPS=ON cmake option
-- export OV_CPU_ENABLE_DNNL_MAMTUL_FOR_FC=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants