[PyOV] Improve import_model memory consumption #27451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirceaDan99
approved these changes
Nov 7, 2024
|
I believe @p-wysocki has a PR that also modifies this, #26237. Please also review. |
akuporos
force-pushed
the
akup/improve-import_model
branch
from
5366eac to
d494128
Compare
akuporos
force-pushed
the
akup/improve-import_model
branch
from
265389d to
982b460
Compare
akuporos
requested review from
ilya-lavrenov,
praasz,
almilosz and
MirceaDan99
praasz
approved these changes
Nov 12, 2024
akuporos
added a commit
to akuporos/openvino
that referenced
this pull request
Nov 22, 2024
### Details: - Writing to stringstream caused additional copy - Usage of fstream also caused extra memory usage. Also we needed to proper handle saving/removal of the tmp_file. - So I've squeezed two `import_model` methods to one and I've implemented/reused custom buffer that wraps interactions with python memory without extra copies ### Tickets: - EISW-137436
NishantPrabhuFujitsu
pushed a commit
to NishantPrabhuFujitsu/openvino
that referenced
this pull request
Nov 26, 2024
### Details: - Writing to stringstream caused additional copy - Usage of fstream also caused extra memory usage. Also we needed to proper handle saving/removal of the tmp_file. - So I've squeezed two `import_model` methods to one and I've implemented/reused custom buffer that wraps interactions with python memory without extra copies ### Tickets: - EISW-137436
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
### Details: - Cherry-pick of: #27534 and #27451 ### Tickets: - *ticket-id* --------- Co-authored-by: Pawel Raasz <[email protected]> Co-authored-by: Roman Kazantsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
import_modelmethods to one and I've implemented/reused custom buffer that wraps interactions with python memory without extra copiesTickets: