Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][STFT] OPENVINO_OP macro for STFT with opset15 #27386

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[Fix][STFT] OPENVINO_OP macro for STFT with opset15 #27386

merged 1 commit into from
Nov 4, 2024

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented Nov 4, 2024 •
edited
Loading

Details:

  • Fix OPENVINO_OP macro for STFT with opset15 (without that it is registered and serialized with version="extension" by default, and can't be deserialized)
  • It follows all of the other ops OPENVINO_OP macro, the "opset15" has been missed for STFT
    Example:

    openvino/src/core/include/openvino/op/slice_scatter.hpp

    Line 17 in 4d8ff86

    OPENVINO_OP("SliceScatter", "opset15");

Tickets:

  • 156667

@mitruska mitruska requested a review from a team as a code owner November 4, 2024 12:28
@mitruska mitruska requested review from mmikolajcz and praasz November 4, 2024 12:28
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Nov 4, 2024
@mitruska mitruska added this to the 2024.5 milestone Nov 4, 2024
@mitruska mitruska self-assigned this Nov 4, 2024
@mitruska
Copy link
Contributor Author

mitruska commented Nov 4, 2024

Approved by @mlukasze to be merged within 2024.5.

@mitruska mitruska enabled auto-merge November 4, 2024 14:35
@mitruska mitruska added this pull request to the merge queue Nov 4, 2024
Merged via the queue into openvinotoolkit:master with commit d69ac00 Nov 4, 2024
166 checks passed
@mitruska mitruska deleted the mitruska/fix_stft_opset branch November 4, 2024 18:11
NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
@mitruska @NishantPrabhuFujitsu
[Fix][STFT] OPENVINO_OP macro for STFT with opset15 (openvinotoolkit#…
23e20d2 
…27386)

### Details:
- Fix OPENVINO_OP macro for STFT with opset15 (without that it is
registered and serialized with version="extension" by default, and can't
be deserialized)
- It follows all of the other ops OPENVINO_OP macro, the "opset15" has
been missed for STFT
Example:
https://github.com/openvinotoolkit/openvino/blob/4d8ff86bd2e853b84a28acd2ece1836d28523f9e/src/core/include/openvino/op/slice_scatter.hpp#L17
 
 

### Tickets:
 - 156667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-wysocki p-wysocki p-wysocki approved these changes

@mmikolajcz mmikolajcz mmikolajcz approved these changes

@praasz praasz Awaiting requested review from praasz

@mlukasze mlukasze Awaiting requested review from mlukasze

Assignees

@mitruska mitruska

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mitruska @mmikolajcz @p-wysocki