[Transformations] Add Squeeze-15 downgrade transformation #27286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: transformations
…kolajcz/openvino into mateuszm/squeeze15/downgrade
mitruska
reviewed
Oct 30, 2024
Comment on lines
+24
to
+25
| if (squeeze_v15->get_input_size() == 1) { | ||
| squeeze_v0 = std::make_shared<op::v0::Squeeze>(squeeze_v15->input_value(0)); |
There was a problem hiding this comment.
v15::Squeeze single input constructor has been extended with allow_axis_skip so the false value should be a common condition
Suggested change
| if (squeeze_v15->get_input_size() == 1) { | |
| squeeze_v0 = std::make_shared<op::v0::Squeeze>(squeeze_v15->input_value(0)); | |
| if (squeeze_v15->get_input_size() == 1 && !squeeze_v15->get_allow_axis_skip()) { | |
| squeeze_v0 = std::make_shared<op::v0::Squeeze>(squeeze_v15->input_value(0)); |
There was a problem hiding this comment.
Or the behavior is the same when axes are not provided?
@barnasm1 Could you confirm?
There was a problem hiding this comment.
The result for empty axes is the same (PartialShape::dynamic()) for both attributes values.
mitruska
approved these changes
Oct 31, 2024
barnasm1
approved these changes
Oct 31, 2024
praasz
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
PR requires PR-26995 to be merged