-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] Init tensor.data when allocating inputs for string type #27269
[GPU] Init tensor.data when allocating inputs for string type #27269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All plugins handle empty strings without throwing but GPU, and this PR adds an additional if check for every string on all plugins. It's a high level fix for a low level issue.
Still, it's a fix for an existing issue, so I approve under the condition that is an additional story or discussion on what the desired plugin behavior for empty string is and adjust GPU if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also expect to see the fix in GPU plugin directly, not in Python API.
As it was described in the ticket by @p-wysocki, the problem is GPU-specific, CPU works well.
a39b4ab
to
c4843a4
Compare
179a200
to
57d56ac
Compare
d3b882f
to
484c727
Compare
GPU implementation was fixed to resolve the issue.
Details:
Tickets: