Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDPD] fix ops for baidu customer #27222

Merged
merged 17 commits into from
Dec 30, 2024
Merged

[PDPD] fix ops for baidu customer #27222

merged 17 commits into from
Dec 30, 2024

Conversation

xczhai
Copy link
Contributor

@xczhai xczhai commented Oct 24, 2024 •
edited
Loading

Details:

  • fix the negative dim issue when run into reduce_fusion pass
  • enable eye op
  • enable elu op
  • add tests
  • upgrade paddlepaddle to 2.6.2
  • upgrade opset to 14 version

Tickets:

  • N/A

@xczhai xczhai requested a review from a team as a code owner October 24, 2024 10:05
@xczhai xczhai changed the title [PDPD]fix dim issue with reduce_sum [PDPD]fix negative dim with reduce_sum Oct 24, 2024
@github-actions github-actions bot added the category: PDPD FE OpenVINO PaddlePaddle FrontEnd label Oct 24, 2024
@xczhai xczhai marked this pull request as draft October 25, 2024 08:54
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: dependency_changes Pull requests that update a dependency file labels Oct 25, 2024
@xczhai xczhai changed the title [PDPD]fix negative dim with reduce_sum [PDPD] fix ops for baidu customer Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Nov 25, 2024
@github-actions github-actions bot removed category: Python API OpenVINO Python bindings category: dependency_changes Pull requests that update a dependency file labels Nov 26, 2024
@github-actions github-actions bot removed the Stale label Dec 7, 2024
@xczhai xczhai marked this pull request as ready for review December 17, 2024 02:19
ceciliapeng2011
ceciliapeng2011 reviewed Dec 24, 2024
View reviewed changes
src/frontends/paddle/src/op/expand_v2.cpp
}
PADDLE_OP_CHECK(node,
input.get_partial_shape().rank().get_length() == 1,
"the rank of conv input must == 1");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this CHECK in need as it's after an unsqueeze node and should definitely be 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this CHECK in need as it's after an unsqueeze node and should definitely be 1?

I see. But PDPD export mechanism always changes from time to time. Sometimes it may be a 0-dim tensor. Sometimes it may be 2-dim tensor. So I have to leave an extra check here.

ceciliapeng2011
ceciliapeng2011 reviewed Dec 24, 2024
View reviewed changes
src/frontends/paddle/src/op/interp.cpp
@@ -4,6 +4,7 @@

#include "default_opset.hpp"
#include "openvino/frontend/paddle/node_context.hpp"
#include "openvino/opsets/opset4.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about upgrade to latest opset too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about upgrade to latest opset too?

Interpolate of OpenVINO opset4 can match PDPD's Interpolate directly.
But Interpolate of the latest opset needs more extra ops to map such op.

ceciliapeng2011
ceciliapeng2011 approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@ceciliapeng2011 ceciliapeng2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

@yuxu42 yuxu42 added this pull request to the merge queue Dec 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2024
@yuxu42 yuxu42 added this pull request to the merge queue Dec 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2024
@yuxu42 yuxu42 added this pull request to the merge queue Dec 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 27, 2024
@xczhai
[PDPD] fix ops for baidu customer (#27222)
9a4b2a2 
### Details:
 - *fix the negative dim issue when run into `reduce_fusion` pass*
 - *enable eye op*
 - *enable elu op*
 - *add tests*
 - *upgrade paddlepaddle to 2.6.2*
 - *upgrade opset to 14 version*

### Tickets:
 - *N/A*
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2024
@xczhai
Copy link
Contributor Author

xczhai commented Dec 27, 2024

@ceciliapeng2011 @yuxu42 could you help add this to merge queue? Thanks.

@yuxu42 yuxu42 added this pull request to the merge queue Dec 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 30, 2024
@yuxu42 yuxu42 added this pull request to the merge queue Dec 30, 2024
Merged via the queue into openvinotoolkit:master with commit 9ab2c1a Dec 30, 2024
174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceciliapeng2011 ceciliapeng2011 Awaiting requested review from ceciliapeng2011

Assignees
No one assigned
Labels
category: PDPD FE OpenVINO PaddlePaddle FrontEnd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xczhai @ceciliapeng2011 @yuxu42