[CPU] Drop redundant MemoryOutput nodes #27189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: IE Tests
xipingyan
reviewed
Oct 23, 2024
|
|
||
| ov::test::utils::compare(tx_result, tx_result_ref, 1e-4, 1e-4); | ||
| ov::test::utils::compare(tz_result, tz_result_ref, 1e-4, 1e-4); | ||
| } |
There was a problem hiding this comment.
Maybe we also need to add check if exist MemoryOutput in compiledModel.
There was a problem hiding this comment.
Yes, for sure, but this is a common test, therefore we cannot add plugin specific checks there. To test the topology we have to introduce a dedicated CPU SL test, and I'm going to do this soon.
xipingyan
reviewed
Oct 23, 2024
Comment on lines
3209
to
3215
| if (Type::MemoryOutput == childNode->getType()) { | ||
| if (MemoryOutput && MemoryOutput != childNode) { | ||
| //only one child MemoryOutput is expected | ||
| return false; | ||
| } | ||
| MemoryOutput = childNode; | ||
| } |
There was a problem hiding this comment.
Is it possible there is a case that ReadValue follows 2 Assginns, only 1 Assgin have same variable ID with current ReadValue?
If yes, I suggest only check if exist ReadValue follow Assgin with same Variable Id. What's your idea?
There was a problem hiding this comment.
Probably it does make sense, you're right. I will extend the condition.
itikhono
reviewed
Oct 24, 2024
itikhono
approved these changes
Oct 24, 2024
|
@xipingyan , do you have any further comments? |
praasz
approved these changes
Oct 25, 2024
|
@dmitry-gorokhov , the PR is ready for the final review. |
dmitry-gorokhov
approved these changes
Oct 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
CuriousPanCake
pushed a commit
to CuriousPanCake/openvino
that referenced
this pull request
Nov 6, 2024
### Details: In direct ReadValue->Assign pairs the Assign node is practically useless as there are no other layers that might modify data in between. Therefore, it does make sense to remove corresponding MemoryOutput nodes to eliminate additional overheads on their processing. ### Tickets: - CVS-153035 - CVS-155112
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
### Details: - *New `ReadValueWithSubgraph` node.* - *Move `ReadValue`'s initial subgraph nodes to `ReadValueWithSubgraph`* - *Mirror `ReadValueWithSubgraph `to `MemoryInput`* - *Upgrade MemoryInput and MemoryInputBase in order to let them support multiple inputs" - *Call new interface `Init` and `Activate` of ov::intel_cpu::Graph, avoid to memory copy. Refer: #25385 - *Depends on #27189 ### Tickets: - *128743* --------- Signed-off-by: xipingya <[email protected]> Co-authored-by: Egor Duplensky <[email protected]> Co-authored-by: Maksim Kutakov <[email protected]> Co-authored-by: Maksim Kutakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In direct ReadValue->Assign pairs the Assign node is practically useless as there are no other layers that might modify data in between. Therefore, it does make sense to remove corresponding MemoryOutput nodes to eliminate additional overheads on their processing.
Tickets: