Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU]support glm4 rope #27094

Merged

Conversation

zhangYiIntel
Copy link
Contributor

Details:

  • Support Rope kernel of GLM4
  • the input data order has changed from ([seq_length, batch, 4608]) in ChatGLM3 to ([batch, seq_length, 4608]) in ChatGLM4. Within RoPE process, the data order changes from ([seq_length, batch, head_count, head_size]) to ([batch, head_count, seq_length, head_size]) by permute operation added in ChatGLM4.
  • the RoPE cache data order has changed from ([seq_length, batch, head_count, 2]) in ChatGLM3 to ([batch, head_count, seq_length, 2]) in ChatGLM4.
  • Consequently, the output of RoPE has also changed from ([seq_length, batch, head_count, head_size]) in ChatGLM3 to ([batch, head_count, seq_length, head_size]) in ChatGLM4
  • Due to these changes, the RoPE pattern matching needs to create something new, something different from what already existed ChatGLM pattern matching. Additionally, new kernels need to be added to accommodate these changes

Tickets:

  • ticket-id

@zhangYiIntel zhangYiIntel added the category: CPU OpenVINO CPU plugin label Oct 17, 2024
@zhangYiIntel zhangYiIntel added this to the 2024.5 milestone Oct 17, 2024
@zhangYiIntel zhangYiIntel requested review from a team as code owners October 17, 2024 02:08
Copy link
Contributor

@luo-cheng2021 luo-cheng2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Oct 17, 2024
Merged via the queue into openvinotoolkit:master with commit 675dc6e Oct 17, 2024
155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants