Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] Fixed IECore constructor #2685

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

likholat
Copy link
Contributor

No description provided.

@likholat likholat requested a review from a team as a code owner October 15, 2020 17:31
@likholat likholat requested a review from a team October 15, 2020 17:31
@openvino-pushbot openvino-pushbot added category: inference OpenVINO Runtime library - Inference category: docs OpenVINO documentation labels Oct 15, 2020
@ilya-lavrenov
Copy link
Contributor

what does it fix?

@likholat
Copy link
Contributor Author

@ilya-lavrenov underscore is a special symbol for JNI:

Dynamic linkers resolve entries based on their names. A native method name is concatenated from the following components:

  • the prefix Java_

  • a mangled fully-qualified class name

  • an underscore (_) separator

  • a mangled method name

If we use underscore for Java native method name, we must add 1 for c++ function name, or the implementation of this method cannot be found, see:
https://stackoverflow.com/questions/32470463/what-is-the-naming-convention-for-java-native-interface-method-and-module-name/32473938#32473938

Or we shouldn't use underscore for native functions names.

@ilya-lavrenov ilya-lavrenov merged commit 347e92c into openvinotoolkit:master Oct 19, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs OpenVINO documentation category: inference OpenVINO Runtime library - Inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants