Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter to execute inference requests at a fixed frequency #26820

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Add parameter to execute inference requests at a fixed frequency #26820

merged 3 commits into from
Nov 13, 2024

Conversation

boonsino
Copy link
Contributor

@boonsino boonsino commented Sep 27, 2024 •
edited
Loading

Details:

  • Add parameter to execute inference requests at a fixed frequency

Tickets:

  • ticket-id

@github-actions github-actions bot added the category: samples OpenVINO Runtime Samples label Sep 27, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalIntelPR External contributor from Intel label Sep 27, 2024
@boonsino boonsino marked this pull request as ready for review September 27, 2024 06:39
@boonsino boonsino requested review from a team as code owners September 27, 2024 06:39
@boonsino boonsino requested review from ilya-lavrenov and removed request for a team September 27, 2024 06:39
@boonsino boonsino force-pushed the add-benchmark-test-fps-arg branch from c962946 to e22a77d Compare September 27, 2024 09:22
ilya-lavrenov
ilya-lavrenov reviewed Sep 27, 2024
View reviewed changes
samples/cpp/benchmark_app/benchmark_app.hpp Outdated
@@ -65,6 +65,11 @@ static const char cache_dir_message[] = "Optional. Enables caching of loaded mod
static const char load_from_file_message[] = "Optional. Loads model from file directly without read_model."
" All CNNNetwork options (like re-shape) will be ignored";

/// @brief message for run frequency
static const char run_frequency_message[] =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in serving it's typically named "requests rate"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name changed. Please check if the new naming matches the OV style

Wovchena
Wovchena requested changes Sep 30, 2024
View reviewed changes
samples/cpp/benchmark_app/benchmark_app.hpp Outdated Show resolved Hide resolved
samples/cpp/benchmark_app/main.cpp Outdated Show resolved Hide resolved
samples/cpp/benchmark_app/main.cpp Outdated Show resolved Hide resolved
samples/cpp/benchmark_app/main.cpp Outdated Show resolved Hide resolved
samples/cpp/benchmark_app/benchmark_app.hpp Outdated Show resolved Hide resolved
samples/cpp/benchmark_app/main.cpp Outdated Show resolved Hide resolved
samples/cpp/benchmark_app/main.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkogteva, what were your reasons against limiting infer requests rate introduction?

@Wovchena
Copy link
Contributor

build_jenkins

@boonsino boonsino requested review from a team as code owners October 30, 2024 06:13
@boonsino boonsino requested review from tsavina and removed request for a team October 30, 2024 06:13
@boonsino boonsino force-pushed the add-benchmark-test-fps-arg branch from 1762638 to 551caa3 Compare October 30, 2024 06:20
@github-actions github-actions bot added category: docs OpenVINO documentation category: tools OpenVINO C++ / Python tools labels Oct 30, 2024
@boonsino boonsino force-pushed the add-benchmark-test-fps-arg branch 2 times, most recently from fa49ebc to 91982ac Compare October 30, 2024 08:26
@boonsino boonsino requested a review from a team as a code owner October 30, 2024 08:26
@m-falkowski @boonsino
Add param to execute infer requests at a fixed frequency
4a6ab42 
Signed-off-by: Maciej Falkowski <[email protected]>
Signed-off-by: Ooi, Boon Sin <[email protected]>
@boonsino boonsino force-pushed the add-benchmark-test-fps-arg branch 3 times, most recently from 7040c62 to 5f5b6d2 Compare November 5, 2024 06:16
@boonsino boonsino requested a review from a team as a code owner November 5, 2024 06:16
@boonsino boonsino removed the request for review from a team November 5, 2024 06:16
@github-actions github-actions bot added the category: dependency_changes Pull requests that update a dependency file label Nov 5, 2024
@boonsino boonsino force-pushed the add-benchmark-test-fps-arg branch from 5f5b6d2 to a751a2f Compare November 13, 2024 02:28
@boonsino boonsino force-pushed the add-benchmark-test-fps-arg branch from a751a2f to 6997144 Compare November 13, 2024 02:37
@github-actions github-actions bot removed the category: dependency_changes Pull requests that update a dependency file label Nov 13, 2024
@Wovchena
Copy link
Contributor

build_jenkins

@Wovchena Wovchena enabled auto-merge November 13, 2024 05:08
auto-merge was automatically disabled November 13, 2024 06:36

Head branch was pushed to by a user without write access

@Wovchena
Copy link
Contributor

build_jenkins

@boonsino boonsino force-pushed the add-benchmark-test-fps-arg branch from 3d2060b to 500f6a1 Compare November 13, 2024 06:47
@Wovchena
Copy link
Contributor

build_jenkins

@Wovchena Wovchena enabled auto-merge November 13, 2024 06:52
@Wovchena Wovchena added this pull request to the merge queue Nov 13, 2024
Merged via the queue into openvinotoolkit:master with commit 79dd358 Nov 13, 2024
166 checks passed
@boonsino boonsino deleted the add-benchmark-test-fps-arg branch November 13, 2024 10:13
NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
@boonsino @m-falkowski @NishantPrabhuFujitsu
Add parameter to execute inference requests at a fixed frequency (ope…
9286843 
…nvinotoolkit#26820)

### Details:
 - Add parameter to execute inference requests at a fixed frequency

### Tickets:
 - *ticket-id*

---------

Signed-off-by: Maciej Falkowski <[email protected]>
Signed-off-by: Ooi, Boon Sin <[email protected]>
Co-authored-by: Maciej Falkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wovchena Wovchena Wovchena approved these changes

@tsavina tsavina Awaiting requested review from tsavina tsavina is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

@AlexKoff88 AlexKoff88 Awaiting requested review from AlexKoff88 AlexKoff88 was automatically assigned from openvinotoolkit/openvino-configuration-mgmt

@artanokhov artanokhov Awaiting requested review from artanokhov artanokhov was automatically assigned from openvinotoolkit/openvino-configuration-mgmt

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov

Assignees

@Wovchena Wovchena

Labels
category: docs OpenVINO documentation category: samples OpenVINO Runtime Samples category: tools OpenVINO C++ / Python tools ExternalIntelPR External contributor from Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boonsino @Wovchena @ilya-lavrenov @sys-openvino-ci @m-falkowski