[NPU] Add pfn build log to pfn-related function #26772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: build
ShaojieZhuIntel
force-pushed
the
pfn_build_log
branch
from
24779ef to
a4e8679
Compare
ShaojieZhuIntel
force-pushed
the
pfn_build_log
branch
3 times, most recently
from
db7943b to
f5b7f8f
Compare
ShaojieZhuIntel
force-pushed
the
pfn_build_log
branch
from
d43a22c to
6db5c1c
Compare
ShaojieZhuIntel
force-pushed
the
pfn_build_log
branch
from
9673977 to
6db5c1c
Compare
pereanub
reviewed
Oct 17, 2024
XinWangIntel
approved these changes
Oct 18, 2024
pereanub
approved these changes
Oct 18, 2024
pereanub
reviewed
Oct 23, 2024
| } | ||
| } | ||
|
|
||
| static inline void throwOnFail(const std::string& step, const ze_result_t result, const std::string& hintOnError) { |
There was a problem hiding this comment.
Is this still needed? Can we keep the same design for all 3 functions?
There was a problem hiding this comment.
Hi, This function is not actually used. It is not known whether it will be used in the future, so the original version is retained. I can change it to a macro definition if we need to.
There was a problem hiding this comment.
I think maybe we can remove the function because it is not actually used.
ShaojieZhuIntel
force-pushed
the
pfn_build_log
branch
from
df5b297 to
2633758
Compare
…ve exception handle fuction that would never be called
ShaojieZhuIntel
force-pushed
the
pfn_build_log
branch
from
2633758 to
ad0b9c5
Compare
ShaojieZhuIntel
force-pushed
the
pfn_build_log
branch
from
ad0b9c5 to
c6089e7
Compare
Merged
via the queue into
openvinotoolkit:master
with commit Oct 23, 2024
5e5c987
131 of 133 checks passed
DanLiu2Intel
pushed a commit
to DanLiu2Intel/openvino
that referenced
this pull request
Nov 5, 2024
There are many OPENVINO_THROW, OPENVINO_ASSERT inside https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_npu/src/compiler/src/zero_compiler_in_driver.cpp, call getLatestBuildError to show error info when pfn-related function is called and remove exception handle fuction that would never be called. Use a macro THROW_ON_FAIL_FOR_LEVELZERO_EXT to simplify exception handling code. There are two functions zeroUtils::throwOnFail() in zero_utils.hpp, but only the two-parameters function zeroUtils::throwOnFail() is actually used. And zeroUtils::throwOnFail() will use its code location instead of the real location where issue happen, so use a macro THROW_ON_FAIL_FOR_LEVELZERO instead of the function zeroUtils::throwOnFail() with two parameters. Function zeroUtils::throwOnFail() with three parameters is preserved. - [EISW-139871](https://jira.devtools.intel.com/browse/EISW-139871)
CuriousPanCake
pushed a commit
to CuriousPanCake/openvino
that referenced
this pull request
Nov 6, 2024
### Details: There are many OPENVINO_THROW, OPENVINO_ASSERT inside https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_npu/src/compiler/src/zero_compiler_in_driver.cpp, call getLatestBuildError to show error info when pfn-related function is called and remove exception handle fuction that would never be called. Use a macro THROW_ON_FAIL_FOR_LEVELZERO_EXT to simplify exception handling code. There are two functions zeroUtils::throwOnFail() in zero_utils.hpp, but only the two-parameters function zeroUtils::throwOnFail() is actually used. And zeroUtils::throwOnFail() will use its code location instead of the real location where issue happen, so use a macro THROW_ON_FAIL_FOR_LEVELZERO instead of the function zeroUtils::throwOnFail() with two parameters. Function zeroUtils::throwOnFail() with three parameters is preserved. ### Tickets: - [EISW-139871](https://jira.devtools.intel.com/browse/EISW-139871)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
There are many OPENVINO_THROW, OPENVINO_ASSERT inside https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_npu/src/compiler/src/zero_compiler_in_driver.cpp, call getLatestBuildError to show error info when pfn-related function is called and remove exception handle fuction that would never be called. Use a macro THROW_ON_FAIL_FOR_LEVELZERO_EXT to simplify exception handling code.
There are two functions zeroUtils::throwOnFail() in zero_utils.hpp, but only the two-parameters function zeroUtils::throwOnFail() is actually used. And zeroUtils::throwOnFail() will use its code location instead of the real location where issue happen, so use a macro THROW_ON_FAIL_FOR_LEVELZERO instead of the function zeroUtils::throwOnFail() with two parameters.
Function zeroUtils::throwOnFail() with three parameters is preserved.
Tickets: