[Spec] Identity operation #26718
Merged
[Spec] Identity operation #26718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Core
rkazants
reviewed
Sep 21, 2024
...n/documentation/openvino-ir-format/operation-sets/operation-specs/activation/identity-15.rst
Outdated
Show resolved
Hide resolved
rkazants
reviewed
Sep 21, 2024
...n/documentation/openvino-ir-format/operation-sets/operation-specs/activation/identity-15.rst
Outdated
Show resolved
Hide resolved
rkazants
reviewed
Sep 21, 2024
mitruska
reviewed
Oct 21, 2024
...n/documentation/openvino-ir-format/operation-sets/operation-specs/activation/identity-15.rst
Outdated
Show resolved
Hide resolved
docs/articles_en/documentation/openvino-ir-format/operation-sets/available-opsets/opset15.rst
Outdated
Show resolved
Hide resolved
docs/articles_en/documentation/openvino-ir-format/operation-sets/available-opsets/opset15.rst
Outdated
Show resolved
Hide resolved
...n/documentation/openvino-ir-format/operation-sets/operation-specs/activation/identity-15.rst
Outdated
Show resolved
Hide resolved
|
This PR will be closed in a week because of 2 weeks of no activity. |
PiotrKrzem
force-pushed
the
feature/spec_identity
branch
from
4eb11f7 to
d5cc27a
Compare
github-actions
bot
added
the
category: extensions
PiotrKrzem
force-pushed
the
feature/spec_identity
branch
from
d5cc27a to
aa619f2
Compare
github-actions
bot
removed
category: Core
github-actions
bot
removed
category: Python API
mitruska
reviewed
Nov 8, 2024
...n/documentation/openvino-ir-format/operation-sets/operation-specs/activation/identity-16.rst
Show resolved
Hide resolved
Signed-off-by: PiotrKrzem <[email protected]>
mitruska
approved these changes
Nov 8, 2024
...n/documentation/openvino-ir-format/operation-sets/operation-specs/activation/identity-16.rst
Outdated
Show resolved
Hide resolved
…ts/operation-specs/activation/identity-16.rst Co-authored-by: Katarzyna Mitrus <[email protected]>
mmikolajcz
approved these changes
Nov 8, 2024
|
|
||
| **Versioned name**: *Identity-16* | ||
|
|
||
| **Category**: *Activation* |
There was a problem hiding this comment.
Activation makes sense, but wouldn't it fit better "Infrastructure" category?
There was a problem hiding this comment.
I was even considering 'internal' myself, I am not sure
There was a problem hiding this comment.
"Internal" is a category of OpenVINO operations which are not a part of public API, so it wouldn't be the right choice. "Infrastracture" is also an option, but "Identity" also called "Linear" is described as a type of activation function in many articles, and this is aligned with detailed op description below. As the category here doesn't affect the op logic or compatibility, in my opinion it's ok leave it as is (but always can be moved).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
### Details: - Add Identity Operation Core & Ref - Spec available here: #26718 - Opset16 initialization files should disappear after merging: #27458 ### Tickets: - 152727 - 152726 --------- Co-authored-by: Mateusz Mikolajczyk <[email protected]>
NishantPrabhuFujitsu
pushed a commit
to NishantPrabhuFujitsu/openvino
that referenced
this pull request
Nov 26, 2024
### Details: - Add Identity Operation Core & Ref - Spec available here: openvinotoolkit#26718 - Opset16 initialization files should disappear after merging: openvinotoolkit#27458 ### Tickets: - 152727 - 152726 --------- Co-authored-by: Mateusz Mikolajczyk <[email protected]>
NishantPrabhuFujitsu
pushed a commit
to NishantPrabhuFujitsu/openvino
that referenced
this pull request
Nov 26, 2024
### Details: - Adds opset15 spec - Adds Identity specification - To be merged after openvinotoolkit#26717 Question for review - is "activation" the correct folder to place this op into, or would "internal" be better? ### Tickets: - 152730 --------- Signed-off-by: PiotrKrzem <[email protected]> Co-authored-by: Katarzyna Mitrus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Question for review - is "activation" the correct folder to place this op into, or would "internal" be better?
Tickets: