[CPU][ARM] Enable fast math in ACL deconvolution executor #26615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,9 @@ struct DeconvAttrs { | |||
| std::vector<ptrdiff_t> paddingR; | |||
| ov::CoordinateDiff outputPadding; | |||
| bool withBiasesParam = false; | |||
| #if defined(OV_CPU_WITH_ACL) | |||
| bool aclFastMath = false; | |||
There was a problem hiding this comment.
I would prefer to avoid backend specific params in common attributes structure.
Doesn't ACL Deconv Executor have direct access to GraphConfig?
There was a problem hiding this comment.
Ok, I think we can merge this as temp solution, but in general it should be refactored.
I would expect to have some backend related properties inside ExecutorContext. @EgorDuplensky what is your opinion?
dmitry-gorokhov
approved these changes
Oct 21, 2024
CuriousPanCake
pushed a commit
to CuriousPanCake/openvino
that referenced
this pull request
Nov 6, 2024
…olkit#26615) ### Details: - ACL deconvolution `fast_math` option is enabled on `PERFORMANCE` mode. - This option enables fast math computation in ACL. In case this flag were set, ACL could dispatch the fastest implementation available which may introduce a drop of accuracy as well. - Accuracy testing on dataset subset highlights some deviations from reference values. Results are attached to the ticket. ### Tickets: - CVS-152534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
fast_mathoption is enabled onPERFORMANCEmode.Tickets: