Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extensions (tokenizers) loading on Android #26437

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fixed extensions (tokenizers) loading on Android #26437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/core/dev_api/openvino/core/so_extension.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ namespace detail {

class OPENVINO_API SOExtension : public Extension {
public:
~SOExtension() {
m_ext = {};
}
virtual ~SOExtension() override;

SOExtension(const Extension::Ptr& ext, const std::shared_ptr<void>& so) : m_ext(ext), m_so(so) {}

Expand Down
2 changes: 1 addition & 1 deletion src/core/include/openvino/core/op_extension.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class OPENVINO_API BaseOpExtension : public Extension {
/**
* @brief Destructor
*/
~BaseOpExtension() override;
virtual ~BaseOpExtension() override;
};

namespace detail {
Expand Down
4 changes: 4 additions & 0 deletions src/core/src/so_extension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

#include "openvino/core/so_extension.hpp"

ov::detail::SOExtension::~SOExtension() {
m_ext.reset();
}

const ov::Extension::Ptr& ov::detail::SOExtension::extension() const {
return m_ext;
}
Expand Down
Loading