Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix some simple typos #26097

Merged
merged 9 commits into from
Aug 24, 2024
Merged

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Aug 17, 2024

No description provided.

@c8ef c8ef requested review from a team as code owners August 17, 2024 02:23
@github-actions github-actions bot added category: GPU OpenVINO GPU plugin category: AUTO OpenVINO AUTO device selection plugin category: AUTO BATCH OpenVINO Auto Batch plugin labels Aug 17, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Aug 17, 2024
@c8ef
Copy link
Contributor Author

c8ef commented Aug 21, 2024

Dear reviewer, could you please take a look at this patch? @sshlyapn

@vladimir-paramuzov
Copy link
Contributor

build_jenkins

@c8ef
Copy link
Contributor Author

c8ef commented Aug 22, 2024

Thank you for your feedback!

@c8ef
Copy link
Contributor Author

c8ef commented Aug 22, 2024

It seems I lack permission to access Jenkins CI data. Can you give more details on the build failure?

@c8ef
Copy link
Contributor Author

c8ef commented Aug 23, 2024

I'm not entirely certain, but the CI failure appears unrelated to my changes. Please let me know if I can assist in moving this forward!

@c8ef
Copy link
Contributor Author

c8ef commented Aug 23, 2024

I'm quite puzzled as to why the ONNX Models Tests keep failing. I haven't even modified that code.

@vladimir-paramuzov
Copy link
Contributor

@c8ef Sometimes jobs fail due to connection issue or some other sporadic issues. Please don't push each time you see the failure, we can just restart failed jobs manually if needed.

@c8ef
Copy link
Contributor Author

c8ef commented Aug 23, 2024

Thank you for your guidance! My motivation is that perhaps some flaky test cases will be resolved in the latest main branch. Therefore, I believe updating the branch would be beneficial for the CI.

auto-merge was automatically disabled August 23, 2024 14:48

Head branch was pushed to by a user without write access

@c8ef c8ef requested a review from a team as a code owner August 23, 2024 14:48
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Aug 23, 2024
@c8ef
Copy link
Contributor Author

c8ef commented Aug 23, 2024

I'm not completely certain, but it appears that the CI problem is a known issue with the current version of pytest. Consider adding a dependency for a workaround.

See also:

@ilya-lavrenov
Copy link
Contributor

build_jenkins

@c8ef
Copy link
Contributor Author

c8ef commented Aug 23, 2024

Great, it seems that adding pytest-randomly has really improved the CI! The only failing CI test now is ie_tests_cldnn_unit_ubuntu20_release, which already passed in commit 72ea9f3. I suspect it may be flaky. Can you assist me in retriggering the failed CI test?

@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Aug 24, 2024
@ilya-lavrenov ilya-lavrenov removed this pull request from the merge queue due to a manual request Aug 24, 2024
@ilya-lavrenov ilya-lavrenov merged commit 66a02fe into openvinotoolkit:master Aug 24, 2024
143 checks passed
@ilya-lavrenov ilya-lavrenov self-assigned this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: AUTO BATCH OpenVINO Auto Batch plugin category: AUTO OpenVINO AUTO device selection plugin category: CI OpenVINO public CI category: GPU OpenVINO GPU plugin ExternalPR External contributor github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants