Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MO] Fix ONNX Clip-11 or higher without min/max inputs #2603

Merged

Conversation

pavel-esir
Copy link
Contributor

@pavel-esir pavel-esir commented Oct 9, 2020

Description: MO has been complaining about ONNX Clip without min. While in ONNX specification these inputs are optional. On the back phase where was ClampNormalizer to deal with it. I just unlocked it by removing unnecessarily strict assert on the Partialnfer of Clamp.

ticket #40312

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests:
  • Framework operation tests: N/A -- no new operations were added
  • Transformation tests: N/A
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py: N/A
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list: N/A
  • Supported public models list: N/A
  • New operations specification: N/A
  • Guide on how to convert the public model: N/A
  • User guide update: N/A

@pavel-esir pavel-esir force-pushed the onnx-clip-initialize-defaults branch from 9a5dcc4 to 03e5fcd Compare October 9, 2020 17:20
@pavel-esir pavel-esir added this to the 2021.2 milestone Oct 9, 2020
@pavel-esir pavel-esir added bug Something isn't working category: MO Model Optimizer labels Oct 9, 2020
@pavel-esir pavel-esir marked this pull request as ready for review October 9, 2020 17:48
@pavel-esir pavel-esir requested a review from a team October 9, 2020 17:48
@lazarevevgeny lazarevevgeny merged commit 9a9b231 into openvinotoolkit:master Oct 12, 2020
@pavel-esir pavel-esir deleted the onnx-clip-initialize-defaults branch October 12, 2020 07:32
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants