[Snippets] Fixed validation checks in BrgemmKernelExecutor::update_config #25978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-gorokhov
approved these changes
Aug 9, 2024
Merged
via the queue into
openvinotoolkit:master
with commit Aug 9, 2024
4e00130
135 of 136 checks passed
mory91
pushed a commit
to mory91/openvino
that referenced
this pull request
Aug 13, 2024
…nfig (openvinotoolkit#25978) ### Details: - *`BrgemmKernelExecutor::update_config` checks Loops with the target `Brgemm` inside that this `Loop` is really by `M, K or N`. Previously we also checked `LoopPort.is_incremented == true`. However, the optimization `CleanRepeatedDataPointerShifts` may set `false` to this attribute when these ports are connected to Buffers with the same GPR (to avoid double pointer increments in execution). This PR lefts only checks for `LoopPort.is_incremented == false` for not incremented ports.* ### Tickets: - *149082*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
BrgemmKernelExecutor::update_configchecks Loops with the targetBrgemminside that thisLoopis really byM, K or N. Previously we also checkedLoopPort.is_incremented == true. However, the optimizationCleanRepeatedDataPointerShiftsmay setfalseto this attribute when these ports are connected to Buffers with the same GPR (to avoid double pointer increments in execution). This PR lefts only checks forLoopPort.is_incremented == falsefor not incremented ports.Tickets: