Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable python3.12 in GHA #25964

Closed
wants to merge 1 commit into from

Conversation

akuporos
Copy link
Contributor

@akuporos akuporos commented Aug 7, 2024

Details:

  • item1
  • ...

Tickets:

@akuporos akuporos requested a review from a team as a code owner August 7, 2024 22:02
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code category: dockerfiles labels Aug 7, 2024
@ilya-lavrenov
Copy link
Contributor

We typically use native python version for Linux OSes.
I suppose other python versions like 3.12 will be added separately within activity of aligning GHA / Jenkins workflows.

@@ -9,21 +9,21 @@ on:
- Code snippets
- Code Style
- Code coverage
- Coverity (Ubuntu 20.04, Python 3.11)
- Coverity (Ubuntu 20.04, Python 3.12)
- Fedora (RHEL), Python 3.9
- Linux (Ubuntu 20.04, Python 3.8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Linux (Ubuntu 20.04, Python 3.8)
- Linux (Ubuntu 20.04, Python 3.12)

@rkazants
Copy link
Member

rkazants commented Aug 8, 2024

We typically use native python version for Linux OSes. I suppose other python versions like 3.12 will be added separately within activity of aligning GHA / Jenkins workflows.

Agree, the default version of Python must be validated as well.

@p-wysocki
Copy link
Contributor

In that case how should we proceed with testing Python 3.12 in GHA? Back when we had Azure we bumped Python version in all jobs, in addition to usual extension of Jenkins pipelines.

Now the situation has changed, and also I suppose GHA cover more code than Azure did. In that case should we:

  • Bump only some GHA jobs to Python 3.12?
  • Introduce new jobs or somehow parametrize existing ones to run Python version checks sequentially like Jenkins does?
  • Keep Python 3.12 testing in Jenkins, as GHA are already testing a single Python version?

cc @akuporos @almilosz @ilya-lavrenov @rkazants

@ilya-lavrenov
Copy link
Contributor

I suggest waiting for "official" GHA work which will align Jenkins and GHA pipelines in terms of Python versions coverage as well.

CC @dorloff

@ilya-lavrenov ilya-lavrenov marked this pull request as draft August 8, 2024 14:39
@akuporos akuporos closed this Sep 9, 2024
@akuporos
Copy link
Contributor Author

akuporos commented Sep 9, 2024

Close it in favor #26466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CI OpenVINO public CI category: dockerfiles github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants