Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "NPU_USE_NPUW" : "NO" case #25926

Merged

Conversation

AsyaPronina
Copy link
Contributor

@AsyaPronina AsyaPronina commented Aug 6, 2024

Details:

  • When "NPU_USE_NPUW" : "NO"/false is passed to intel_npu::Plugin::compile_model(...), it is not removed from incoming OV properties and passes on right to npu plugin's intel_npu::Config config causing:
    [ NOT_FOUND ] Option 'NPU_USE_NPUW' is not supported for current configuration
  • However, workaround for issue is available: just not passing "NPU_USE_NPUW" : "NO" will result in right behavior is you don't need NPUW.

Tickets:

  • ticket-id

@AsyaPronina AsyaPronina requested review from a team as code owners August 6, 2024 10:56
@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label Aug 6, 2024
@dmatveev dmatveev self-assigned this Aug 6, 2024
@dmatveev dmatveev added this to the 2024.3 milestone Aug 6, 2024
@ilya-lavrenov
Copy link
Contributor

is it possible to add a test fox this fix?

@AsyaPronina
Copy link
Contributor Author

is it possible to add a test fox this fix?

Hello, sure, but only for future releases, because infrastructure for tests is not merged yet: Added MockNPU/CPU, FakeNPU/CPU and functional tests by AsyaPronina · Pull Request #25236 · openvinotoolkit/openvino (github.com)

@AsyaPronina AsyaPronina added the category: NPUW NPUW plugin label Aug 6, 2024
@dmatveev dmatveev added this pull request to the merge queue Aug 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
@dmatveev dmatveev added this pull request to the merge queue Aug 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
@dmatveev
Copy link
Contributor

dmatveev commented Aug 7, 2024

@ilya-lavrenov could you please help with a merge? it seems the only failure in this PR checks is somewhere in PyTorch and changes in the PR has no effect on it

@akladiev akladiev merged commit df7381e into openvinotoolkit:releases/2024/3 Aug 7, 2024
93 of 95 checks passed
@dmatveev
Copy link
Contributor

dmatveev commented Aug 7, 2024

@AsyaPronina this PR is merged, do you have the same for master ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants