Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] remove rewrite_graph.hpp #25853

Merged
merged 19 commits into from
Aug 23, 2024
Merged

Conversation

andrei-cv
Copy link
Contributor

Details:

  • remove rewrite_graph.hpp

Tickets:

@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations category: LP transformations OpenVINO Low Precision transformations category: CPP API OpenVINO CPP API bindings labels Aug 1, 2024
@p-durandin p-durandin marked this pull request as ready for review August 8, 2024 10:40
@p-durandin p-durandin requested review from a team as code owners August 8, 2024 10:40
@p-durandin p-durandin requested review from itikhono and removed request for a team August 8, 2024 10:40
src/core/include/openvino/pass/GraphRewrite.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/pass/NodeRegistry.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/pass/NodeRegistry.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/pass/GraphRewrite.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/pass/GraphRewrite.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/pass/GraphRewrite.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/pass/NodeRegistry.hpp Outdated Show resolved Hide resolved
@andrei-cv andrei-cv requested review from a team as code owners August 22, 2024 02:06
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Aug 22, 2024
Copy link
Contributor

@olpipi olpipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +5 to +9
#include "openvino/pass/node_registry.hpp"

void ov::pass::NodeRegistry::clear() {
m_nodes.clear();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to keep in header. But ok

@@ -14,6 +14,7 @@

#include "openvino/cc/pass/itt.hpp"
#include "openvino/op/util/multi_subgraph_base.hpp"
#include "openvino/pass/backward_graph_rewrite.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets fix in next PR

@p-durandin p-durandin added this pull request to the merge queue Aug 23, 2024
Merged via the queue into openvinotoolkit:master with commit 458a6bb Aug 23, 2024
143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: LP transformations OpenVINO Low Precision transformations category: Python API OpenVINO Python bindings category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants