[opset5] ngraph implementation of Loop op #2583
Conversation
itikhono
added
category: inference
| @@ -809,6 +810,7 @@ void convertFunctionToICNNNetwork(const std::shared_ptr<const ::ngraph::Function | |||
| std::make_shared<Builder::NodeConverter<::ngraph::op::TopKIE>>(), | |||
| std::make_shared<Builder::NodeConverter<::ngraph::op::Unsqueeze>>(), | |||
| std::make_shared<Builder::NodeConverter<::ngraph::op::TensorIterator>>(), | |||
| std::make_shared<Builder::NodeConverter<::ngraph::opset5::Loop>>(), | |||
There was a problem hiding this comment.
Why you add node converter? Could you use visitorAPI?
There was a problem hiding this comment.
For now, the old NodeConverter of TensorIterator is used for Loop op with small specific (NodeConverter < Loop > just sets the name of the Loop operation), but this code has not been fully tested for Loop yet due to lack of plugin implementation and unsupported Const-> Results subgraphs.
I guess it's not a blocker for this PR. NodeConverter logic can be moved to the new SpecificCreator for both TI and Loop ops in the next PR.
inference-engine/tests/functional/plugin/shared/include/single_layer_tests/loop.hpp
Outdated
Show resolved
Hide resolved
| auto ngPrc = FuncTestUtils::PrecisionUtils::convertIE2nGraphPrc(netPrecision); | ||
|
|
||
| // That which we iterate over | ||
| std::vector<std::vector<size_t>> inputs_separate; |
There was a problem hiding this comment.
may be, we should move to the builders this large part of code?
There was a problem hiding this comment.
It is not yet clear how to do this if we want to test different ngraph functions inside the Loop and it's just a prototype, now these tests are disabled.
They will be enabled and finalized in the next PR
itikhono
requested review from
GlebKazantaev,
ilyachur,
AlexPeskov and
iefode
* Loop op ngraph implementation, update IE IR Reader and ngraph to cnn converter * refactoring SubGraphOp class * type prop unit tests * ngraph code style * update comment * single layer tests for Loop operation * fix file name * Add SpecialBodyPorts attribute in Loop op, update single layer tests * add several new tests cases, strict checks in Loop impl, temporary disable single layer tests * ngraph codestyle, refactoring, clone_new_args test * resolve review remarks * fix build * fix tests * add a new constructor of Loop op, resolve review remarks
ngraph implementation of Loop op
prototype for reading Loop op from IR in IE IR Reader
prototype for converting Loop to CNN layer
single layer tests in disabled state
shape inference and copy tests