Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OV JS] Enable CompiledModel set/get property() #25808

Merged
merged 8 commits into from
Aug 14, 2024
Merged

[OV JS] Enable CompiledModel set/get property() #25808

merged 8 commits into from
Aug 14, 2024

Conversation

hub-bla
Copy link
Contributor

@hub-bla hub-bla commented Jul 30, 2024

Details:

  • add 2 methods: CompiledModel::set_property() and CompiledModel::get_property()
  • create TypeScript definition for new created methods
  • create unit tests for new functionalities (due to the issue that was mentioned here, it's more of a mock now and should be altered as soon as the issue is fixed)

Tickets:

  • 134825

@hub-bla hub-bla requested a review from a team as a code owner July 30, 2024 17:31
@github-actions github-actions bot added the category: JS API OpenVino JS API Bindings label Jul 30, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jul 30, 2024
@hub-bla hub-bla marked this pull request as draft August 1, 2024 10:25
@hub-bla hub-bla marked this pull request as ready for review August 7, 2024 07:05
@almilosz almilosz linked an issue Aug 8, 2024 that may be closed by this pull request
[Good First Issue]: Enable CompiledModel set/get property() #24374
Closed
almilosz
almilosz reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@almilosz almilosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please look at my comments :)

src/bindings/js/node/lib/addon.ts Outdated Show resolved Hide resolved
src/bindings/js/node/lib/addon.ts Outdated Show resolved Hide resolved
src/bindings/js/node/lib/addon.ts Outdated Show resolved Hide resolved
src/bindings/js/node/lib/addon.ts Outdated Show resolved Hide resolved
src/bindings/js/node/lib/addon.ts Outdated Show resolved Hide resolved
src/bindings/js/node/src/compiled_model.cpp Outdated Show resolved Hide resolved
src/bindings/js/node/src/compiled_model.cpp Outdated Show resolved Hide resolved
src/bindings/js/node/src/compiled_model.cpp Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/compiled_model.test.js Outdated Show resolved Hide resolved
almilosz
almilosz approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@almilosz almilosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Green light from me

@almilosz
Copy link
Contributor

build_jenkins

@almilosz almilosz added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@vishniakov-nikolai vishniakov-nikolai added this pull request to the merge queue Aug 14, 2024
Merged via the queue into openvinotoolkit:master with commit 98e4c36 Aug 14, 2024
137 checks passed
@mlukasze mlukasze added this to the 2024.4 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almilosz almilosz almilosz approved these changes

Assignees
No one assigned
Labels
category: JS API OpenVino JS API Bindings ExternalPR External contributor
Projects
None yet
Milestone
2024.4
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Enable CompiledModel set/get property()
5 participants
@hub-bla @almilosz @mlukasze @vishniakov-nikolai @sys-openvino-ci