Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Fix issue to calculate present layout's padding for KVCache #25682

Merged
merged 2 commits into from
Jul 23, 2024
Merged

[GPU] Fix issue to calculate present layout's padding for KVCache #25682

merged 2 commits into from
Jul 23, 2024

Conversation

andrew-k-park
Copy link
Contributor

Details:

  • Fix issue to calculate present layout's padding for KVCache

Tickets:

  • 146876

@andrew-k-park andrew-k-park added the category: GPU OpenVINO GPU plugin label Jul 23, 2024
@andrew-k-park andrew-k-park requested review from a team as code owners July 23, 2024 01:30
@yeonbok yeonbok added this pull request to the merge queue Jul 23, 2024
Merged via the queue into openvinotoolkit:master with commit bb5a9d4 Jul 23, 2024
108 checks passed
@yeonbok yeonbok deleted the fix_issue_chat_sample branch July 23, 2024 19:19
@andrew-k-park andrew-k-park mentioned this pull request Jul 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 24, 2024
@andrew-k-park
[GPU] Fix remaininig issue to calculate present layout's padding for …
eeb8fe9 
…KVCache (#25706)

### Details:
- Follow up remaining issue from
#25682
- Fix issue where kvcache was optimized out even if calculated present
layout's padding was negative

### Tickets:
 - 146876
akuporos pushed a commit to akuporos/openvino that referenced this pull request Jul 25, 2024
@andrew-k-park @akuporos
[GPU] Fix issue to calculate present layout's padding for KVCache (op…
175195b 
…envinotoolkit#25682)

### Details:
 - Fix issue to calculate present layout's padding for KVCache

### Tickets:
 - 146876
akuporos pushed a commit to akuporos/openvino that referenced this pull request Jul 25, 2024
@andrew-k-park @akuporos
[GPU] Fix remaininig issue to calculate present layout's padding for …
7d1904f 
…KVCache (openvinotoolkit#25706)

### Details:
- Follow up remaining issue from
openvinotoolkit#25682
- Fix issue where kvcache was optimized out even if calculated present
layout's padding was negative

### Tickets:
 - 146876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeonbok yeonbok yeonbok approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-k-park @yeonbok