Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Extended impls factory and onednn impls update #25680

Merged
merged 15 commits into from
Sep 25, 2024
Merged

[GPU] Extended impls factory and onednn impls update #25680

merged 15 commits into from
Sep 25, 2024

Conversation

vladimir-paramuzov
Copy link
Contributor

@vladimir-paramuzov vladimir-paramuzov commented Jul 22, 2024 •
edited
Loading

Details:

  • Changed impl registration and selection logic. All impls now are registered in prioritized list along with validation function and optional custom callback.
  • Added impls factory interface which extends existing impl creation capability with validation method + query for preferred formats.
  • Move onednn-specific logic from layout optimizer to onednn-based impls.
  • Move onednn descriptors creation to cpp file to avoid further usage in other components
  • Removed unused eltwise_onednn impl files

@vladimir-paramuzov vladimir-paramuzov added the category: GPU OpenVINO GPU plugin label Jul 22, 2024
@vladimir-paramuzov vladimir-paramuzov requested review from a team as code owners July 22, 2024 18:20
@vladimir-paramuzov vladimir-paramuzov force-pushed the refactor_impl_selection branch from dda3fd0 to 5b3e9e4 Compare July 23, 2024 05:40
@vladimir-paramuzov vladimir-paramuzov added no_stale Do not mark as stale WIP work in progress labels Aug 5, 2024
@vladimir-paramuzov vladimir-paramuzov force-pushed the refactor_impl_selection branch 4 times, most recently from 1a90318 to 14c8917 Compare August 15, 2024 13:28
@vladimir-paramuzov vladimir-paramuzov force-pushed the refactor_impl_selection branch 4 times, most recently from 15fcb5a to 36f795b Compare August 23, 2024 13:53
@moslex moslex added this to the 2024.4 milestone Aug 26, 2024
@vladimir-paramuzov vladimir-paramuzov force-pushed the refactor_impl_selection branch 10 times, most recently from 8ecc59d to 55f6701 Compare September 2, 2024 13:11
@vladimir-paramuzov vladimir-paramuzov force-pushed the refactor_impl_selection branch 2 times, most recently from 974183d to 10a445b Compare September 4, 2024 13:09
@vladimir-paramuzov vladimir-paramuzov force-pushed the refactor_impl_selection branch 2 times, most recently from d6550d8 to 3cedb37 Compare September 20, 2024 10:05
@vladimir-paramuzov vladimir-paramuzov mentioned this pull request Sep 20, 2024
Merged
ilya-lavrenov pushed a commit that referenced this pull request Sep 20, 2024
@vladimir-paramuzov
Cherry pick some changes to llama branch (#26709)
c973dbf 
### Details:
- #26708 and last commit
from #25680
@vladimir-paramuzov vladimir-paramuzov force-pushed the refactor_impl_selection branch 2 times, most recently from 1cd9ab5 to 1042153 Compare September 22, 2024 14:22
@vladimir-paramuzov vladimir-paramuzov removed WIP work in progress no_stale Do not mark as stale labels Sep 25, 2024
@vladimir-paramuzov vladimir-paramuzov modified the milestones: 2024.4, 2024.5 Sep 25, 2024
@p-durandin p-durandin added this pull request to the merge queue Sep 25, 2024
Merged via the queue into openvinotoolkit:master with commit 3a99145 Sep 25, 2024
136 checks passed
@vladimir-paramuzov vladimir-paramuzov deleted the refactor_impl_selection branch September 25, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lyamin-Roman Lyamin-Roman Lyamin-Roman left review comments

@isanghao isanghao isanghao left review comments

@yeonbok yeonbok yeonbok approved these changes

@sshlyapn sshlyapn sshlyapn approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
7 participants
@vladimir-paramuzov @sshlyapn @isanghao @yeonbok @Lyamin-Roman @moslex @p-durandin