[GPU] Add condition for dynamic shape split_lengths for in place crop buffer fusing #25595
Conversation
wilson-seok
force-pushed
the
fix_runtime_in_place_crop_for_dynamic_shape
branch
from
679a50a to
6f06699
Compare
| // The VariadicSplit shape infer requires executed value of input[2](split_lengths) | ||
| // So skip update_shape here when _node is input[2] of crop | ||
| auto crop_op_mode = u->_impl_params->typed_desc<crop>()->op_mode; | ||
| bool is_split_lengths = (crop_op_mode == cldnn::crop_ngraph_op_mode::variadic_split) && |
There was a problem hiding this comment.
crop has 3 inputs and do_runtime_in_place_crop is executed twice in previous 2 inputs before split_lenth node. but this condition only checks where current node is 3rd input or not.
Under this condition, isn't it possible that update_shape of crop is done before the split_length node is executed?
There was a problem hiding this comment.
Actually axis and split_lengths nodes are executed before input0. And axis should have valid number because it is mandatory to check crop buffer fusing in build time.
There was a problem hiding this comment.
Isn't it better to check user crop's 2nd input is non_constant?
There was a problem hiding this comment.
@yeonbok do_runtime_in_place_crop() is not called when node is constant. So checking non_constant here is not feasible.
There was a problem hiding this comment.
@yeonbok Updated as we discussed. Thanks!
…it and any one of input1 and input2 is not constant
Details:
Tickets: