Skip new params for old driver compiler #25453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinWangIntel
force-pushed
the
remove-new-params-for-old-driver
branch
from
5a7584b to
0d9ecb1
Compare
XinWangIntel
force-pushed
the
remove-new-params-for-old-driver
branch
from
0d9ecb1 to
244573e
Compare
github-actions
bot
added
category: inference
MirceaDan99
approved these changes
Jul 9, 2024
ArtemySkrebkov
approved these changes
Jul 9, 2024
nikita-kud
reviewed
Jul 9, 2024
| optLevelStr << "optimization-level" << KEY_VALUE_SEPARATOR << "\\d+"; | ||
| std::ostringstream perfHintStr; | ||
| perfHintStr << "performance-hint-override" << KEY_VALUE_SEPARATOR << "\\S+"; | ||
| _logger.warning( |
There was a problem hiding this comment.
Should not we first check if ptimization-level/performance-hint-override are present?
auto areOptionsSupported = (compilerVersion.major > 5) || (compilerVersion.major == 5 && compilerVersion.minor > 7);
auto contaisOptions = content.contains(optLevelStr) || content.contains(perfHintStr); // pseudo-code
if (!areOptionsSupported && contaisOptions) {
// write message
// remove options
}
There was a problem hiding this comment.
Added more strict check now, please help to review again
XinWangIntel
force-pushed
the
remove-new-params-for-old-driver
branch
from
4f1070b to
178281d
Compare
XinWangIntel
force-pushed
the
remove-new-params-for-old-driver
branch
from
178281d to
9f14590
Compare
spran180
pushed a commit
to spran180/openvino
that referenced
this pull request
Jul 27, 2024
### Details: There are new added options for NPU_COMPILATION_MODE_PARAMS, need to skip for old driver compiler. ### Tickets: - *146197*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
There are new added options for NPU_COMPILATION_MODE_PARAMS, need to skip for old driver compiler.
Tickets: