Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] update shape for fused prims #25363

Merged

Conversation

ahnyoung-paul
Copy link
Contributor

Details:

  • update shape for user when current node is the input of fused prim of user even if the user is updated shape by other node
  • ...

Tickets:

  • 145756

@ahnyoung-paul ahnyoung-paul requested review from a team as code owners July 3, 2024 13:33
auto is_fused_prim_of_user = [&](primitive_id id) -> bool {
for (auto& p : user->get_node().get_fused_primitives()) {
if (p.has_outer_dep()) {
if (user->get_node().get_dependency(p.outer_dep_start_idx).id() == id) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there is multiple fused inputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

@yeonbok
Copy link
Contributor

yeonbok commented Jul 3, 2024

Please add a unittest

@ahnyoung-paul
Copy link
Contributor Author

Please add a unittest

I will update it.

@yeonbok
Copy link
Contributor

yeonbok commented Jul 4, 2024

Unittest will come soon

@yeonbok yeonbok added this pull request to the merge queue Jul 4, 2024
@ahnyoung-paul ahnyoung-paul removed pr: needs tests PR needs tests updating under_perf_check labels Jul 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2024
@p-durandin p-durandin added this pull request to the merge queue Jul 4, 2024
Merged via the queue into openvinotoolkit:master with commit 01dc53a Jul 4, 2024
106 checks passed
isanghao added a commit to isanghao/openvino that referenced this pull request Jul 5, 2024
This reverts commit 01dc53a.
Reverting this PR because it is causing LLM failures
github-merge-queue bot pushed a commit that referenced this pull request Jul 5, 2024
This reverts commit 01dc53a. Reverting
this PR because it is causing LLM failures

### Tickets:
 - 145784
ieliz pushed a commit to ieliz/openvino that referenced this pull request Jul 5, 2024
…penvinotoolkit#25395)

This reverts commit 01dc53a. Reverting
this PR because it is causing LLM failures

### Tickets:
 - 145784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants