-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] update shape for fused prims #25363
Merged
p-durandin
merged 2 commits into
openvinotoolkit:master
from
ahnyoung-paul:update_shape_for_fused_prims
Jul 4, 2024
Merged
[GPU] update shape for fused prims #25363
p-durandin
merged 2 commits into
openvinotoolkit:master
from
ahnyoung-paul:update_shape_for_fused_prims
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonbok
reviewed
Jul 3, 2024
auto is_fused_prim_of_user = [&](primitive_id id) -> bool { | ||
for (auto& p : user->get_node().get_fused_primitives()) { | ||
if (p.has_outer_dep()) { | ||
if (user->get_node().get_dependency(p.outer_dep_start_idx).id() == id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if there is multiple fused inputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it.
Please add a unittest |
ahnyoung-paul
added
pr: needs tests
PR needs tests updating
under_perf_check
and removed
under_perf_check
labels
Jul 3, 2024
I will update it. |
yeonbok
approved these changes
Jul 4, 2024
Unittest will come soon |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 4, 2024
isanghao
added a commit
to isanghao/openvino
that referenced
this pull request
Jul 5, 2024
This reverts commit 01dc53a. Reverting this PR because it is causing LLM failures
ieliz
pushed a commit
to ieliz/openvino
that referenced
this pull request
Jul 5, 2024
…penvinotoolkit#25395) This reverts commit 01dc53a. Reverting this PR because it is causing LLM failures ### Tickets: - 145784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: