fix cmake path issue #25251
Closed
fix cmake path issue #25251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ can't find Windows SDK version. Try to use vcvarsall.bat script") | |||
| endif() | |||
| endif() | |||
|
|
|||
| set(PROGRAMFILES_ENV "ProgramFiles\(X86\)") | |||
| set(PROGRAMFILES_ENV "ProgramFiles\(X86\)" PARENT_SCOPE) | |||
There was a problem hiding this comment.
it's not used outside of this function, do we need to move to parent scope ?
What issue do you experience?
There was a problem hiding this comment.
Hi, when build locally, can not find the UniversalDDIs.xml
[2024-06-26T21:58:25.848Z] CMake Error at cmake/developer_package/api_validator/api_validator.cmake:124 (message):
[2024-06-26T21:58:25.848Z] Internal error: apiValidator is found (C:/Program Files (x86)/Windows
[2024-06-26T21:58:25.848Z] Kits/10/bin/10.0.22621.0/x64/apivalidator.exe), but UniversalDDIs.xml file
[2024-06-26T21:58:25.848Z] has not been found for x64 platform
by test locally, find the path is '/Windows Kits/10/build/10.0.19041.0/universalDDIs/x64/UniversalDDIs.xml'
${PROGRAMFILES_ENV} in here is used to search UniversalDDIs.xml.
find_file(ONECORE_API_VALIDATOR_APIS NAMES UniversalDDIs.xml
PATHS "${PROGRAMFILES}/Windows Kits/10/build/${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION}/universalDDIs/${wdk_platform}"
"${PROGRAMFILES}/Windows Kits/10/build/universalDDIs/${wdk_platform}"
DOC "Path to UniversalDDIs.xml file")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
_ov_add_api_validator_post_build_stepfunction.${PROGRAMFILES}is empty and defined in functionov_search_api_validator.Tickets: