-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] [GHA] Add Dockerfile for Android ARM64, use it in workflow #25130
Merged
akashchi
merged 38 commits into
openvinotoolkit:master
from
akashchi:ci/gha/docker-android-arm64
Jun 26, 2024
Merged
[CI] [GHA] Add Dockerfile for Android ARM64, use it in workflow #25130
akashchi
merged 38 commits into
openvinotoolkit:master
from
akashchi:ci/gha/docker-android-arm64
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: CI
OpenVINO public CI
github_actions
Pull requests that update GitHub Actions code
category: dockerfiles
labels
Jun 19, 2024
akashchi
commented
Jun 24, 2024
Comment on lines
+18
to
+32
apt install \ | ||
scons \ | ||
wget \ | ||
ninja-build \ | ||
build-essential \ | ||
python3-pip && \ | ||
# vcpkg requires cmake 3.19 or later | ||
python3 -m pip install -U pip cmake~=3.28.0 && \ | ||
# vcpkg's tool dependencies | ||
apt install curl zip unzip tar && \ | ||
# vcpkg 'python3' port dependencies | ||
apt install autoconf libtool autoconf-archive && \ | ||
# vcpkg tree of dependencies require extra packages | ||
apt install pkgconf linux-libc-dev && \ | ||
apt --no-install-recommends install default-jdk && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If combined into one apt install
, apt
cannot determine the matching versions for all the packages and breaks.
ilya-lavrenov
approved these changes
Jun 24, 2024
mryzhov
reviewed
Jun 26, 2024
apt install autoconf libtool autoconf-archive && \ | ||
# vcpkg tree of dependencies require extra packages | ||
apt install pkgconf linux-libc-dev && \ | ||
apt --no-install-recommends install default-jdk && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
apt --no-install-recommends install default-jdk && \ | |
apt install default-jdk && \ |
mryzhov
approved these changes
Jun 26, 2024
allnes
pushed a commit
to allnes/openvino
that referenced
this pull request
Jun 27, 2024
…vinotoolkit#25130) ### Tickets: - *144477*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: CI
OpenVINO public CI
category: dockerfiles
github_actions
Pull requests that update GitHub Actions code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets: