Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LPT] ReduceSum: zero point support #24977

Merged

Conversation

eshoguli
Copy link
Contributor

Details:

  • [LPT] ReduceSum: zero point support

Tickets:

@eshoguli eshoguli requested review from a team as code owners June 12, 2024 12:46
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: LP transformations OpenVINO Low Precision transformations labels Jun 12, 2024
@eshoguli eshoguli requested a review from v-Golubev June 12, 2024 12:46
@eshoguli eshoguli added this to the 2023.3 milestone Jun 12, 2024
@eshoguli eshoguli requested a review from v-Golubev June 12, 2024 15:36
@eshoguli eshoguli force-pushed the es/lpt/reduce_sum_zero_point_support branch from 56f4c52 to cb3a247 Compare June 12, 2024 15:39
OV_PP_ET_LIST(f32, f64, i32, i64, u32, u64),
OV_PP_ET_LIST(f32, f64, i8, i32, i64, u8, u32, u64),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to support i8 & u8 reference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant why do we need to support i8/u8 reference in this PR ;) It seems like we don't need these changes. However, I was just curious, don't see anything bad in that. We can leave it as is

@eshoguli eshoguli requested a review from v-Golubev June 12, 2024 17:34
@eshoguli eshoguli force-pushed the es/lpt/reduce_sum_zero_point_support branch 2 times, most recently from 14a8f47 to 4f44307 Compare June 12, 2024 17:37
@eshoguli eshoguli added this pull request to the merge queue Jun 13, 2024
@eshoguli eshoguli removed this pull request from the merge queue due to a manual request Jun 13, 2024
@eshoguli eshoguli added this pull request to the merge queue Jun 13, 2024
Merged via the queue into openvinotoolkit:master with commit 5769fab Jun 13, 2024
118 checks passed
@eshoguli eshoguli deleted the es/lpt/reduce_sum_zero_point_support branch June 13, 2024 12:13
github-merge-queue bot pushed a commit that referenced this pull request Jun 16, 2024
### Details:
 - *[LPT] ReduceSum: zero point support*
 - *Original PR: #24977

### Tickets:
 - *CVS-142256*
allnes pushed a commit to allnes/openvino that referenced this pull request Jun 27, 2024
### Details:
 - *[LPT] ReduceSum: zero point support*

### Tickets:
 - *CVS-142256*
allnes pushed a commit to allnes/openvino that referenced this pull request Jun 27, 2024
…olkit#25011)

### Details:
 - *[LPT] ReduceSum: zero point support*
 - *Original PR: openvinotoolkit#24977

### Tickets:
 - *CVS-142256*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph) category: LP transformations OpenVINO Low Precision transformations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants